* linux-next: origin tree build warning
@ 2009-06-11 1:27 Stephen Rothwell
2009-06-11 10:29 ` [PATCH] x86: memtest: fix compile warning Andreas Herrmann
0 siblings, 1 reply; 38+ messages in thread
From: Stephen Rothwell @ 2009-06-11 1:27 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra
Cc: linux-next, linux-kernel, Andreas Herrmann
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
Hi all,
Today's linux-next build (x86_64 allmodconfig) produced this warning:
arch/x86/mm/memtest.c: In function 'memtest':
arch/x86/mm/memtest.c:56: warning: comparison of distinct pointer types lacks a cast
arch/x86/mm/memtest.c:58: warning: comparison of distinct pointer types lacks a cast
Introduced by commit c9690998ef48ffefeccb91c70a7739eebdea57f9 ("x86:
memtest: remove 64-bit division").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* [PATCH] x86: memtest: fix compile warning
2009-06-11 1:27 linux-next: origin tree build warning Stephen Rothwell
@ 2009-06-11 10:29 ` Andreas Herrmann
2009-06-11 11:57 ` [tip:branch?] x86: memtest: add proper typecast for pointer comparison tip-bot for Andreas Herrmann
2009-06-11 14:21 ` [PATCH] x86: memtest: fix compile warning Thomas Gleixner
0 siblings, 2 replies; 38+ messages in thread
From: Andreas Herrmann @ 2009-06-11 10:29 UTC (permalink / raw)
To: Stephen Rothwell, Ingo Molnar, Thomas Gleixner
Cc: H. Peter Anvin, Peter Zijlstra, linux-next, linux-kernel
Commit c9690998ef48ffefeccb91c70a7739eebdea57f9
(x86: memtest: remove 64-bit division) introduced following compile warning:
arch/x86/mm/memtest.c: In function 'memtest':
arch/x86/mm/memtest.c:56: warning: comparison of distinct pointer types lacks a cast
arch/x86/mm/memtest.c:58: warning: comparison of distinct pointer types lacks a cast
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
---
arch/x86/mm/memtest.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Sorry.
Please apply.
Thanks,
Andreas
diff --git a/arch/x86/mm/memtest.c b/arch/x86/mm/memtest.c
index c0bedcd..1a8b48f 100644
--- a/arch/x86/mm/memtest.c
+++ b/arch/x86/mm/memtest.c
@@ -53,9 +53,9 @@ static void __init memtest(u64 pattern, u64 start_phys, u64 size)
start_bad = 0;
last_bad = 0;
- for (p = start; p < end; p++)
+ for (p = start; (void *) p < end; p++)
*p = pattern;
- for (p = start; p < end; p++, start_phys_aligned += incr) {
+ for (p = start; (void *) p < end; p++, start_phys_aligned += incr) {
if (*p == pattern)
continue;
if (start_phys_aligned == last_bad + incr) {
--
1.6.3.1
^ permalink raw reply [flat|nested] 38+ messages in thread* [tip:branch?] x86: memtest: add proper typecast for pointer comparison
2009-06-11 10:29 ` [PATCH] x86: memtest: fix compile warning Andreas Herrmann
@ 2009-06-11 11:57 ` tip-bot for Andreas Herrmann
2009-06-11 14:21 ` [PATCH] x86: memtest: fix compile warning Thomas Gleixner
1 sibling, 0 replies; 38+ messages in thread
From: tip-bot for Andreas Herrmann @ 2009-06-11 11:57 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, andreas.herrmann3, tglx
Commit-ID: 47e64f3c8430d0410c8e83f3e503532491c863c3
Gitweb: http://git.kernel.org/tip/47e64f3c8430d0410c8e83f3e503532491c863c3
Author: Andreas Herrmann <andreas.herrmann3@amd.com>
AuthorDate: Thu, 11 Jun 2009 12:29:27 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 11 Jun 2009 13:53:02 +0200
x86: memtest: add proper typecast for pointer comparison
Commit c9690998ef48ffefeccb91c70a7739eebdea57f9
(x86: memtest: remove 64-bit division) introduced following compile warning:
arch/x86/mm/memtest.c: In function 'memtest':
arch/x86/mm/memtest.c:56: warning: comparison of distinct pointer types lacks a cast
arch/x86/mm/memtest.c:58: warning: comparison of distinct pointer types lacks a cast
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
LKML-Reference: <20090611102927.GE12431@alberich.amd.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/mm/memtest.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/mm/memtest.c b/arch/x86/mm/memtest.c
index c0bedcd..1a8b48f 100644
--- a/arch/x86/mm/memtest.c
+++ b/arch/x86/mm/memtest.c
@@ -53,9 +53,9 @@ static void __init memtest(u64 pattern, u64 start_phys, u64 size)
start_bad = 0;
last_bad = 0;
- for (p = start; p < end; p++)
+ for (p = start; (void *) p < end; p++)
*p = pattern;
- for (p = start; p < end; p++, start_phys_aligned += incr) {
+ for (p = start; (void *) p < end; p++, start_phys_aligned += incr) {
if (*p == pattern)
continue;
if (start_phys_aligned == last_bad + incr) {
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH] x86: memtest: fix compile warning
2009-06-11 10:29 ` [PATCH] x86: memtest: fix compile warning Andreas Herrmann
2009-06-11 11:57 ` [tip:branch?] x86: memtest: add proper typecast for pointer comparison tip-bot for Andreas Herrmann
@ 2009-06-11 14:21 ` Thomas Gleixner
2009-06-11 14:30 ` H. Peter Anvin
` (2 more replies)
1 sibling, 3 replies; 38+ messages in thread
From: Thomas Gleixner @ 2009-06-11 14:21 UTC (permalink / raw)
To: Andreas Herrmann
Cc: Stephen Rothwell, Ingo Molnar, H. Peter Anvin, Peter Zijlstra,
linux-next, linux-kernel
On Thu, 11 Jun 2009, Andreas Herrmann wrote:
> Commit c9690998ef48ffefeccb91c70a7739eebdea57f9
> (x86: memtest: remove 64-bit division) introduced following compile warning:
>
> arch/x86/mm/memtest.c: In function 'memtest':
> arch/x86/mm/memtest.c:56: warning: comparison of distinct pointer types lacks a cast
> arch/x86/mm/memtest.c:58: warning: comparison of distinct pointer types lacks a cast
>
> Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
> ---
> arch/x86/mm/memtest.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> Sorry.
> Please apply.
I applied it already, but zapped it right away, as it is bad style to
do the type casting in the loops. The proper fix is below.
But aside of that this code is confusing.
start_phys_aligned = ALIGN(start_phys, incr);
Why do we have to fiddle with the alignment. Are you really seing e820
entries which are not 8 byte aligned ?
for (p = start; p < end; p++, start_phys_aligned += incr) {
if (*p == pattern)
continue;
if (start_phys_aligned == last_bad + incr) {
last_bad += incr;
continue;
}
if (start_bad)
reserve_bad_mem(pattern, start_bad, last_bad + incr);
start_bad = last_bad = start_phys_aligned;
}
if (start_bad)
reserve_bad_mem(pattern, start_bad, last_bad + incr);
I really had to look more than once to understand what the heck
start_phys_aligned and last_bad + incr are doing. Really non
intuitive.
But the reserve_bad_mem() semantics are even more scary:
- if you hit flaky memory, which gives you bad and good results here
and there, you call reserve_bad_mem() totally unbound which is
likely to overflow the early reservation space and panics the
machine. You need to keep track of those events somehow (e.g. in a
bitmap) so you can detect such problems and mark the whole affected
region bad in one go.
- you call reserve_early() which calls __reserve_early(....,
overrun_ok = 0) so if you do the default multi pattern scan and each
run sees the same region of broken memory you will trigger the
"Overlapping early reservations" panic in __reserve_early() when you
reserve that region the second time. Why do you run the test twice
when the first one failed already ? Also there is no need to do the
wipeout run in that case, which will trigger it as well!
So in both cases you panic the machine w/o need.
Please fix ASAP.
Thanks,
tglx
---
diff --git a/arch/x86/mm/memtest.c b/arch/x86/mm/memtest.c
index d1c5cef..18d244f 100644
--- a/arch/x86/mm/memtest.c
+++ b/arch/x86/mm/memtest.c
@@ -40,16 +40,14 @@ static void __init reserve_bad_mem(u64 pattern, u64 start_bad, u64 end_bad)
static void __init memtest(u64 pattern, u64 start_phys, u64 size)
{
- u64 *p, *end;
- void *start;
+ u64 *p, *start, *end;
u64 start_bad, last_bad;
u64 start_phys_aligned;
- size_t incr;
+ const size_t incr = sizeof(pattern);
- incr = sizeof(pattern);
start_phys_aligned = ALIGN(start_phys, incr);
start = __va(start_phys_aligned);
- end = (u64 *) (start + size - (start_phys_aligned - start_phys));
+ end = start + (size - (start_phys_aligned - start_phys)) / incr;
start_bad = 0;
last_bad = 0;
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH] x86: memtest: fix compile warning
2009-06-11 14:21 ` [PATCH] x86: memtest: fix compile warning Thomas Gleixner
@ 2009-06-11 14:30 ` H. Peter Anvin
2009-06-11 15:26 ` Andreas Herrmann
2009-06-11 17:19 ` Yinghai Lu
2 siblings, 0 replies; 38+ messages in thread
From: H. Peter Anvin @ 2009-06-11 14:30 UTC (permalink / raw)
To: Thomas Gleixner
Cc: Andreas Herrmann, Stephen Rothwell, Ingo Molnar, Peter Zijlstra,
linux-next, linux-kernel
Thomas Gleixner wrote:
>
> But aside of that this code is confusing.
>
> start_phys_aligned = ALIGN(start_phys, incr);
>
> Why do we have to fiddle with the alignment. Are you really seing e820
> entries which are not 8 byte aligned ?
>
I have personally seen those on real systems.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH] x86: memtest: fix compile warning
2009-06-11 14:21 ` [PATCH] x86: memtest: fix compile warning Thomas Gleixner
2009-06-11 14:30 ` H. Peter Anvin
@ 2009-06-11 15:26 ` Andreas Herrmann
2009-06-12 13:11 ` Andreas Herrmann
2009-06-11 17:19 ` Yinghai Lu
2 siblings, 1 reply; 38+ messages in thread
From: Andreas Herrmann @ 2009-06-11 15:26 UTC (permalink / raw)
To: Thomas Gleixner
Cc: Stephen Rothwell, Ingo Molnar, H. Peter Anvin, Peter Zijlstra,
linux-next, linux-kernel, Yinghai Lu
On Thu, Jun 11, 2009 at 04:21:41PM +0200, Thomas Gleixner wrote:
> On Thu, 11 Jun 2009, Andreas Herrmann wrote:
>
> > Commit c9690998ef48ffefeccb91c70a7739eebdea57f9
> > (x86: memtest: remove 64-bit division) introduced following compile warning:
> >
> > arch/x86/mm/memtest.c: In function 'memtest':
> > arch/x86/mm/memtest.c:56: warning: comparison of distinct pointer types lacks a cast
> > arch/x86/mm/memtest.c:58: warning: comparison of distinct pointer types lacks a cast
> >
> > Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
> > ---
> > arch/x86/mm/memtest.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > Sorry.
> > Please apply.
>
> I applied it already, but zapped it right away, as it is bad style to
> do the type casting in the loops. The proper fix is below.
Doesn't your fix re-introduces the 64-bit division problem with old
gcc? I removed that division with the mentioned commit just forgot to
type-cast the pointer.
> But aside of that this code is confusing.
>
> start_phys_aligned = ALIGN(start_phys, incr);
>
>
> Why do we have to fiddle with the alignment. Are you really seing e820
> entries which are not 8 byte aligned ?
CC-ing Yinghai who might know more about this.
See also http://marc.info/?l=linux-kernel&m=123490434528131
> for (p = start; p < end; p++, start_phys_aligned += incr) {
> if (*p == pattern)
> continue;
> if (start_phys_aligned == last_bad + incr) {
> last_bad += incr;
> continue;
> }
> if (start_bad)
> reserve_bad_mem(pattern, start_bad, last_bad + incr);
> start_bad = last_bad = start_phys_aligned;
> }
> if (start_bad)
> reserve_bad_mem(pattern, start_bad, last_bad + incr);
>
> I really had to look more than once to understand what the heck
> start_phys_aligned and last_bad + incr are doing. Really non
> intuitive.
>
> But the reserve_bad_mem() semantics are even more scary:
>
> - if you hit flaky memory, which gives you bad and good results here
> and there, you call reserve_bad_mem() totally unbound which is
> likely to overflow the early reservation space and panics the
> machine. You need to keep track of those events somehow (e.g. in a
> bitmap) so you can detect such problems and mark the whole affected
> region bad in one go.
Agreed, needs to be fixed.
> - you call reserve_early() which calls __reserve_early(....,
> overrun_ok = 0) so if you do the default multi pattern scan and each
> run sees the same region of broken memory you will trigger the
> "Overlapping early reservations" panic in __reserve_early() when you
> reserve that region the second time. Why do you run the test twice
> when the first one failed already ? Also there is no need to do the
> wipeout run in that case, which will trigger it as well!
Sure, needs to be fixed as well.
(Note: I think both problems exist in the memtest code right from the beginning.)
> So in both cases you panic the machine w/o need.
>
> Please fix ASAP.
> Thanks,
>
> tglx
> ---
> diff --git a/arch/x86/mm/memtest.c b/arch/x86/mm/memtest.c
> index d1c5cef..18d244f 100644
> --- a/arch/x86/mm/memtest.c
> +++ b/arch/x86/mm/memtest.c
> @@ -40,16 +40,14 @@ static void __init reserve_bad_mem(u64 pattern, u64 start_bad, u64 end_bad)
>
> static void __init memtest(u64 pattern, u64 start_phys, u64 size)
> {
> - u64 *p, *end;
> - void *start;
> + u64 *p, *start, *end;
> u64 start_bad, last_bad;
> u64 start_phys_aligned;
> - size_t incr;
> + const size_t incr = sizeof(pattern);
>
> - incr = sizeof(pattern);
> start_phys_aligned = ALIGN(start_phys, incr);
> start = __va(start_phys_aligned);
> - end = (u64 *) (start + size - (start_phys_aligned - start_phys));
> + end = start + (size - (start_phys_aligned - start_phys)) / incr;
> start_bad = 0;
> last_bad = 0;
>
Regards,
Andreas
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH] x86: memtest: fix compile warning
2009-06-11 15:26 ` Andreas Herrmann
@ 2009-06-12 13:11 ` Andreas Herrmann
0 siblings, 0 replies; 38+ messages in thread
From: Andreas Herrmann @ 2009-06-12 13:11 UTC (permalink / raw)
To: Thomas Gleixner
Cc: Stephen Rothwell, Ingo Molnar, H. Peter Anvin, Peter Zijlstra,
linux-next, linux-kernel, Yinghai Lu
On Thu, Jun 11, 2009 at 05:26:58PM +0200, Andreas Herrmann wrote:
> On Thu, Jun 11, 2009 at 04:21:41PM +0200, Thomas Gleixner wrote:
> > On Thu, 11 Jun 2009, Andreas Herrmann wrote:
> >
> > > Commit c9690998ef48ffefeccb91c70a7739eebdea57f9
> > > (x86: memtest: remove 64-bit division) introduced following compile warning:
> > >
> > > arch/x86/mm/memtest.c: In function 'memtest':
> > > arch/x86/mm/memtest.c:56: warning: comparison of distinct pointer types lacks a cast
> > > arch/x86/mm/memtest.c:58: warning: comparison of distinct pointer types lacks a cast
> > >
> > > Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
> > > ---
> > > arch/x86/mm/memtest.c | 4 ++--
> > > 1 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > Sorry.
> > > Please apply.
> >
> > I applied it already, but zapped it right away, as it is bad style to
> > do the type casting in the loops. The proper fix is below.
>
> Doesn't your fix re-introduces the 64-bit division problem with old
> gcc? I removed that division with the mentioned commit just forgot to
> type-cast the pointer.
It doesn't.
> > diff --git a/arch/x86/mm/memtest.c b/arch/x86/mm/memtest.c
> > index d1c5cef..18d244f 100644
> > --- a/arch/x86/mm/memtest.c
> > +++ b/arch/x86/mm/memtest.c
> > @@ -40,16 +40,14 @@ static void __init reserve_bad_mem(u64 pattern, u64 start_bad, u64 end_bad)
> >
> > static void __init memtest(u64 pattern, u64 start_phys, u64 size)
> > {
> > - u64 *p, *end;
> > - void *start;
> > + u64 *p, *start, *end;
> > u64 start_bad, last_bad;
> > u64 start_phys_aligned;
> > - size_t incr;
> > + const size_t incr = sizeof(pattern);
The const qualifier made the difference.
Thanks,
Andreas
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH] x86: memtest: fix compile warning
2009-06-11 14:21 ` [PATCH] x86: memtest: fix compile warning Thomas Gleixner
2009-06-11 14:30 ` H. Peter Anvin
2009-06-11 15:26 ` Andreas Herrmann
@ 2009-06-11 17:19 ` Yinghai Lu
2009-06-11 21:05 ` Thomas Gleixner
2 siblings, 1 reply; 38+ messages in thread
From: Yinghai Lu @ 2009-06-11 17:19 UTC (permalink / raw)
To: Thomas Gleixner
Cc: Andreas Herrmann, Stephen Rothwell, Ingo Molnar, H. Peter Anvin,
Peter Zijlstra, linux-next, linux-kernel
On Thu, Jun 11, 2009 at 7:21 AM, Thomas Gleixner<tglx@linutronix.de> wrote:
> On Thu, 11 Jun 2009, Andreas Herrmann wrote:
>
>> Commit c9690998ef48ffefeccb91c70a7739eebdea57f9
>> (x86: memtest: remove 64-bit division) introduced following compile warning:
>>
>> arch/x86/mm/memtest.c: In function 'memtest':
>> arch/x86/mm/memtest.c:56: warning: comparison of distinct pointer types lacks a cast
>> arch/x86/mm/memtest.c:58: warning: comparison of distinct pointer types lacks a cast
>>
>> Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
>> ---
>> arch/x86/mm/memtest.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> Sorry.
>> Please apply.
>
> I applied it already, but zapped it right away, as it is bad style to
> do the type casting in the loops. The proper fix is below.
>
> But aside of that this code is confusing.
>
> start_phys_aligned = ALIGN(start_phys, incr);
>
> Why do we have to fiddle with the alignment. Are you really seing e820
> entries which are not 8 byte aligned ?
>
> for (p = start; p < end; p++, start_phys_aligned += incr) {
> if (*p == pattern)
> continue;
> if (start_phys_aligned == last_bad + incr) {
> last_bad += incr;
> continue;
> }
> if (start_bad)
> reserve_bad_mem(pattern, start_bad, last_bad + incr);
> start_bad = last_bad = start_phys_aligned;
> }
> if (start_bad)
> reserve_bad_mem(pattern, start_bad, last_bad + incr);
>
> I really had to look more than once to understand what the heck
> start_phys_aligned and last_bad + incr are doing. Really non
> intuitive.
>
> But the reserve_bad_mem() semantics are even more scary:
>
> - if you hit flaky memory, which gives you bad and good results here
> and there, you call reserve_bad_mem() totally unbound which is
> likely to overflow the early reservation space and panics the
> machine. You need to keep track of those events somehow (e.g. in a
> bitmap) so you can detect such problems and mark the whole affected
> region bad in one go.
if one pass found bad, it is reserved.
second pass will use find_e820_area_size() to get new range, so bad
one will not be used.
>
> - you call reserve_early() which calls __reserve_early(....,
> overrun_ok = 0) so if you do the default multi pattern scan and each
> run sees the same region of broken memory you will trigger the
> "Overlapping early reservations" panic in __reserve_early() when you
> reserve that region the second time. Why do you run the test twice
> when the first one failed already ? Also there is no need to do the
> wipeout run in that case, which will trigger it as well!
current problem in that: we could run out of res_reserve array.
solution will be make res_reserve array dynamically.
when can not find slot, need use find_e820_area to get double sized,
and copy the old to new one.
then free the old one.
YH
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH] x86: memtest: fix compile warning
2009-06-11 17:19 ` Yinghai Lu
@ 2009-06-11 21:05 ` Thomas Gleixner
0 siblings, 0 replies; 38+ messages in thread
From: Thomas Gleixner @ 2009-06-11 21:05 UTC (permalink / raw)
To: Yinghai Lu
Cc: Andreas Herrmann, Stephen Rothwell, Ingo Molnar, H. Peter Anvin,
Peter Zijlstra, linux-next, linux-kernel
On Thu, 11 Jun 2009, Yinghai Lu wrote:
> On Thu, Jun 11, 2009 at 7:21 AM, Thomas Gleixner<tglx@linutronix.de> wrote:
> > On Thu, 11 Jun 2009, Andreas Herrmann wrote:
> > But the reserve_bad_mem() semantics are even more scary:
> >
> > - if you hit flaky memory, which gives you bad and good results here
> > and there, you call reserve_bad_mem() totally unbound which is
> > likely to overflow the early reservation space and panics the
> > machine. You need to keep track of those events somehow (e.g. in a
> > bitmap) so you can detect such problems and mark the whole affected
> > region bad in one go.
>
> if one pass found bad, it is reserved.
> second pass will use find_e820_area_size() to get new range, so bad
> one will not be used.
No, that's not about passes. Assume that you have flaky memory which
works halfways. So that code runs through a full memory region from 0
to 0x1000000.
0-FF OK
100-1ff BAD
200-21f OK
220-23f BAD
....
So there is no find_e820_area_size() between those OK/BAD steps, but
every new BAD hit calls reserve_early() and you run out of space in
the reserve array.
> > - you call reserve_early() which calls __reserve_early(....,
> > overrun_ok = 0) so if you do the default multi pattern scan and each
> > run sees the same region of broken memory you will trigger the
> > "Overlapping early reservations" panic in __reserve_early() when you
> > reserve that region the second time. Why do you run the test twice
> > when the first one failed already ? Also there is no need to do the
> > wipeout run in that case, which will trigger it as well!
Ok, here applies the find_e820_area_size() thing. I missed that
because the code is so well documented and obvious.
> current problem in that: we could run out of res_reserve array.
> solution will be make res_reserve array dynamically.
> when can not find slot, need use find_e820_area to get double sized,
> and copy the old to new one.
> then free the old one.
This applies to the first problem, which can be avoided by clever
coding.
Thanks,
tglx
^ permalink raw reply [flat|nested] 38+ messages in thread
* linux-next: origin tree build warning
@ 2010-01-27 0:09 Stephen Rothwell
0 siblings, 0 replies; 38+ messages in thread
From: Stephen Rothwell @ 2010-01-27 0:09 UTC (permalink / raw)
To: Dave Airlie; +Cc: linux-next, linux-kernel, Jerome Glisse
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
Hi all,
Today's linux-next build (x86_64 allmodconfig) produced this warning:
drivers/gpu/drm/radeon/radeon_agp.c: In function 'radeon_agp_init':
drivers/gpu/drm/radeon/radeon_agp.c:137: warning: format '%d' expects type 'int', but argument 4 has type 'size_t'
Introduced by commit 0a3f316370da07fcdb11fde4f5a683d60713b7fd
("drm/radeon/kms: Disable AGP is aperture size < 32M").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* linux-next: origin tree build warning
@ 2010-01-18 4:05 Stephen Rothwell
2010-01-18 4:14 ` Stephen Rothwell
0 siblings, 1 reply; 38+ messages in thread
From: Stephen Rothwell @ 2010-01-18 4:05 UTC (permalink / raw)
To: Linus; +Cc: linux-next, linux-kernel, Wu Fengguang, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]
Hi all,
Today's linux-next build (x86_64_allmodconfig) produced these warnings:
drivers/base/memory.c:319: warning: initialization from incompatible pointer type
drivers/base/memory.c:353: warning: initialization from incompatible pointer type
drivers/base/memory.c:408: warning: initialization from incompatible pointer type
drivers/base/memory.c:409: warning: initialization from incompatible pointer type
Introduced by commit 8ff410daa009c4b44be445ded5b0cec00abc0426 ("sysdev:
fix prototype for memory_sysdev_class show/store functions").
The third parameter to SYSDEV_CLASS_ATTR should be a "ssize_t (*)(struct
sysdev_class *, char *)", but this commit changes them to "ssize_t (*)
(struct sysdev_class *, struct sysdev_class_attribute *, char *buf)". Or
maybe the definition of "struct sysdev_class_attribute" is wrong?
It actually looks like commit c29af9636 ("sysdev: Pass attribute in
sysdev_class attributes show/store") referred to in the changelog for the
above commit has not yet been applied to Linus' tree?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: linux-next: origin tree build warning
2010-01-18 4:05 Stephen Rothwell
@ 2010-01-18 4:14 ` Stephen Rothwell
2010-01-18 4:29 ` Wu, Fengguang
0 siblings, 1 reply; 38+ messages in thread
From: Stephen Rothwell @ 2010-01-18 4:14 UTC (permalink / raw)
To: Linus; +Cc: linux-next, linux-kernel, Wu Fengguang, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
Hi all,
On Mon, 18 Jan 2010 15:05:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> It actually looks like commit c29af9636 ("sysdev: Pass attribute in
> sysdev_class attributes show/store") referred to in the changelog for the
> above commit has not yet been applied to Linus' tree?
Commit c29af9636 ("sysdev: Pass attribute in sysdev_class attributes
show/store") does appear in linux-next since next-20100111 (in the
driver-core quilt series - therefore intended for 2.6.34) (it will have a
different SHA1 today)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* RE: linux-next: origin tree build warning
2010-01-18 4:14 ` Stephen Rothwell
@ 2010-01-18 4:29 ` Wu, Fengguang
2010-01-18 5:40 ` Stephen Rothwell
0 siblings, 1 reply; 38+ messages in thread
From: Wu, Fengguang @ 2010-01-18 4:29 UTC (permalink / raw)
To: Stephen Rothwell, Linus; +Cc: linux-next, linux-kernel, Andrew Morton
On Mon, 18 Jan 2010 15:05:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > It actually looks like commit c29af9636 ("sysdev: Pass attribute in
> > sysdev_class attributes show/store") referred to in the changelog for the
> > above commit has not yet been applied to Linus' tree?
>
> Commit c29af9636 ("sysdev: Pass attribute in sysdev_class attributes
> show/store") does appear in linux-next since next-20100111 (in the
> driver-core quilt series - therefore intended for 2.6.34) (it will have a
> different SHA1 today)
So let's queue 8ff410daa009c (sysdev: fix prototype for memory_sysdev_class show/store functions)
in driver-core and delay it to 2.6.34?
Thanks,
Fengguang
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: linux-next: origin tree build warning
2010-01-18 4:29 ` Wu, Fengguang
@ 2010-01-18 5:40 ` Stephen Rothwell
2010-01-19 0:12 ` Stephen Rothwell
0 siblings, 1 reply; 38+ messages in thread
From: Stephen Rothwell @ 2010-01-18 5:40 UTC (permalink / raw)
To: Wu, Fengguang
Cc: Greg KH, Andi Kleen, Linus, linux-next, linux-kernel, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 988 bytes --]
Hi Fengguang,
On Mon, 18 Jan 2010 12:29:52 +0800 "Wu, Fengguang" <fengguang.wu@intel.com> wrote:
>
> On Mon, 18 Jan 2010 15:05:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > It actually looks like commit c29af9636 ("sysdev: Pass attribute in
> > > sysdev_class attributes show/store") referred to in the changelog for the
> > > above commit has not yet been applied to Linus' tree?
> >
> > Commit c29af9636 ("sysdev: Pass attribute in sysdev_class attributes
> > show/store") does appear in linux-next since next-20100111 (in the
> > driver-core quilt series - therefore intended for 2.6.34) (it will have a
> > different SHA1 today)
>
> So let's queue 8ff410daa009c (sysdev: fix prototype for memory_sysdev_class show/store functions)
> in driver-core and delay it to 2.6.34?
Then it would need to be reverted from Linus' tree.
Greg?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: linux-next: origin tree build warning
2010-01-18 5:40 ` Stephen Rothwell
@ 2010-01-19 0:12 ` Stephen Rothwell
2010-01-19 21:05 ` Greg KH
0 siblings, 1 reply; 38+ messages in thread
From: Stephen Rothwell @ 2010-01-19 0:12 UTC (permalink / raw)
To: Wu, Fengguang
Cc: Greg KH, Andi Kleen, Linus, linux-next, linux-kernel, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]
Hi Fengguang,
On Mon, 18 Jan 2010 16:40:39 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Mon, 18 Jan 2010 12:29:52 +0800 "Wu, Fengguang" <fengguang.wu@intel.com> wrote:
> >
> > On Mon, 18 Jan 2010 15:05:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > >
> > > > It actually looks like commit c29af9636 ("sysdev: Pass attribute in
> > > > sysdev_class attributes show/store") referred to in the changelog for the
> > > > above commit has not yet been applied to Linus' tree?
> > >
> > > Commit c29af9636 ("sysdev: Pass attribute in sysdev_class attributes
> > > show/store") does appear in linux-next since next-20100111 (in the
> > > driver-core quilt series - therefore intended for 2.6.34) (it will have a
> > > different SHA1 today)
> >
> > So let's queue 8ff410daa009c (sysdev: fix prototype for memory_sysdev_class show/store functions)
> > in driver-core and delay it to 2.6.34?
>
> Then it would need to be reverted from Linus' tree.
I have reverted commit 8ff410daa009c for today. It looks like Greg
already has the alternate patches queued in the driver-core tree to take
care of this problem when it arises.
So, Greg, can you ask Linus to revert 8ff410daa009c (sysdev: fix
prototype for memory_sysdev_class show/store functions), please? Or
should I? Or should we hope he notices these emails? :-)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: linux-next: origin tree build warning
2010-01-19 0:12 ` Stephen Rothwell
@ 2010-01-19 21:05 ` Greg KH
2010-01-19 21:11 ` Greg KH
0 siblings, 1 reply; 38+ messages in thread
From: Greg KH @ 2010-01-19 21:05 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Wu, Fengguang, Andi Kleen, Linus, linux-next, linux-kernel,
Andrew Morton
On Tue, Jan 19, 2010 at 11:12:26AM +1100, Stephen Rothwell wrote:
> Hi Fengguang,
>
> On Mon, 18 Jan 2010 16:40:39 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Mon, 18 Jan 2010 12:29:52 +0800 "Wu, Fengguang" <fengguang.wu@intel.com> wrote:
> > >
> > > On Mon, 18 Jan 2010 15:05:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > > >
> > > > > It actually looks like commit c29af9636 ("sysdev: Pass attribute in
> > > > > sysdev_class attributes show/store") referred to in the changelog for the
> > > > > above commit has not yet been applied to Linus' tree?
> > > >
> > > > Commit c29af9636 ("sysdev: Pass attribute in sysdev_class attributes
> > > > show/store") does appear in linux-next since next-20100111 (in the
> > > > driver-core quilt series - therefore intended for 2.6.34) (it will have a
> > > > different SHA1 today)
> > >
> > > So let's queue 8ff410daa009c (sysdev: fix prototype for memory_sysdev_class show/store functions)
> > > in driver-core and delay it to 2.6.34?
> >
> > Then it would need to be reverted from Linus' tree.
>
> I have reverted commit 8ff410daa009c for today. It looks like Greg
> already has the alternate patches queued in the driver-core tree to take
> care of this problem when it arises.
>
> So, Greg, can you ask Linus to revert 8ff410daa009c (sysdev: fix
> prototype for memory_sysdev_class show/store functions), please? Or
> should I? Or should we hope he notices these emails? :-)
No, I think the patch in Linus's tree is correct, so I have fixed up my
tree now.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: linux-next: origin tree build warning
2010-01-19 21:05 ` Greg KH
@ 2010-01-19 21:11 ` Greg KH
2010-01-19 23:47 ` Stephen Rothwell
0 siblings, 1 reply; 38+ messages in thread
From: Greg KH @ 2010-01-19 21:11 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Wu, Fengguang, Andi Kleen, Linus, linux-next, linux-kernel,
Andrew Morton
On Tue, Jan 19, 2010 at 01:05:14PM -0800, Greg KH wrote:
> On Tue, Jan 19, 2010 at 11:12:26AM +1100, Stephen Rothwell wrote:
> > Hi Fengguang,
> >
> > On Mon, 18 Jan 2010 16:40:39 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > On Mon, 18 Jan 2010 12:29:52 +0800 "Wu, Fengguang" <fengguang.wu@intel.com> wrote:
> > > >
> > > > On Mon, 18 Jan 2010 15:05:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > > > >
> > > > > > It actually looks like commit c29af9636 ("sysdev: Pass attribute in
> > > > > > sysdev_class attributes show/store") referred to in the changelog for the
> > > > > > above commit has not yet been applied to Linus' tree?
> > > > >
> > > > > Commit c29af9636 ("sysdev: Pass attribute in sysdev_class attributes
> > > > > show/store") does appear in linux-next since next-20100111 (in the
> > > > > driver-core quilt series - therefore intended for 2.6.34) (it will have a
> > > > > different SHA1 today)
> > > >
> > > > So let's queue 8ff410daa009c (sysdev: fix prototype for memory_sysdev_class show/store functions)
> > > > in driver-core and delay it to 2.6.34?
> > >
> > > Then it would need to be reverted from Linus' tree.
> >
> > I have reverted commit 8ff410daa009c for today. It looks like Greg
> > already has the alternate patches queued in the driver-core tree to take
> > care of this problem when it arises.
> >
> > So, Greg, can you ask Linus to revert 8ff410daa009c (sysdev: fix
> > prototype for memory_sysdev_class show/store functions), please? Or
> > should I? Or should we hope he notices these emails? :-)
>
> No, I think the patch in Linus's tree is correct, so I have fixed up my
> tree now.
Ick, no, you are correct, Wu's patch shouldn't have been sent to Linus
yet. I'll revert it, and then keep the fixes that were in my tree,
which should make everything safe for the .34 merge.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: linux-next: origin tree build warning
2010-01-19 21:11 ` Greg KH
@ 2010-01-19 23:47 ` Stephen Rothwell
0 siblings, 0 replies; 38+ messages in thread
From: Stephen Rothwell @ 2010-01-19 23:47 UTC (permalink / raw)
To: Greg KH
Cc: Wu, Fengguang, Andi Kleen, Linus, linux-next, linux-kernel,
Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
Hi Greg,
On Tue, 19 Jan 2010 13:11:17 -0800 Greg KH <greg@kroah.com> wrote:
>
> Ick, no, you are correct, Wu's patch shouldn't have been sent to Linus
> yet. I'll revert it, and then keep the fixes that were in my tree,
> which should make everything safe for the .34 merge.
Great, thanks.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
[parent not found: <20100101112914.41bc5f77.sfr@canb.auug.org.au>]
* Re: linux-next: origin tree build warning
[not found] <20100101112914.41bc5f77.sfr@canb.auug.org.au>
@ 2010-01-01 0:34 ` Linus Torvalds
2010-01-01 1:02 ` Stephen Rothwell
0 siblings, 1 reply; 38+ messages in thread
From: Linus Torvalds @ 2010-01-01 0:34 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Rafael J. Wysocki
On Fri, 1 Jan 2010, Stephen Rothwell wrote:
>
> Today's linux-next build (powerpc allnoconfig) produced this warning:
>
> drivers/pci/quirks.c: In function 'pci_dev_specific_reset':
> drivers/pci/quirks.c:2699: warning: assignment discards qualifiers from pointer target type
>
> Introduced by commit 5b889bf237fca383b5807ad69fde3ad1e2287e42 ("PCI: Fix
> build if quirks are not enabled").
Does this trivial patch get rid of it?
Linus
---
drivers/pci/quirks.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 5c449fc..c746943 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2694,7 +2694,7 @@ static const struct pci_dev_reset_methods pci_dev_reset_methods[] = {
int pci_dev_specific_reset(struct pci_dev *dev, int probe)
{
- struct pci_dev_reset_methods *i;
+ const struct pci_dev_reset_methods *i;
for (i = pci_dev_reset_methods; i->reset; i++) {
if ((i->vendor == dev->vendor ||
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: linux-next: origin tree build warning
2010-01-01 0:34 ` Linus Torvalds
@ 2010-01-01 1:02 ` Stephen Rothwell
2010-01-01 1:16 ` Rafael J. Wysocki
0 siblings, 1 reply; 38+ messages in thread
From: Stephen Rothwell @ 2010-01-01 1:02 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-next, linux-kernel, Rafael J. Wysocki
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
Hi Linus,
On Thu, 31 Dec 2009 16:34:37 -0800 (PST) Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Fri, 1 Jan 2010, Stephen Rothwell wrote:
> >
> > Today's linux-next build (powerpc allnoconfig) produced this warning:
>
> Does this trivial patch get rid of it?
Yep.
Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
I did actually get this warning for all sorts of configs/architectures,
obviously, I just reported it against the first that popped up.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: linux-next: origin tree build warning
2010-01-01 1:02 ` Stephen Rothwell
@ 2010-01-01 1:16 ` Rafael J. Wysocki
0 siblings, 0 replies; 38+ messages in thread
From: Rafael J. Wysocki @ 2010-01-01 1:16 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Linus Torvalds, linux-next, linux-kernel
On Friday 01 January 2010, Stephen Rothwell wrote:
> Hi Linus,
>
> On Thu, 31 Dec 2009 16:34:37 -0800 (PST) Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > On Fri, 1 Jan 2010, Stephen Rothwell wrote:
> > >
> > > Today's linux-next build (powerpc allnoconfig) produced this warning:
> >
> > Does this trivial patch get rid of it?
>
> Yep.
>
> Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> I did actually get this warning for all sorts of configs/architectures,
> obviously, I just reported it against the first that popped up.
Sorry for that, should have double checked.
Rafael
^ permalink raw reply [flat|nested] 38+ messages in thread
* linux-next: origin tree build warning
@ 2009-12-17 0:10 Stephen Rothwell
0 siblings, 0 replies; 38+ messages in thread
From: Stephen Rothwell @ 2009-12-17 0:10 UTC (permalink / raw)
To: Linus; +Cc: linux-next, linux-kernel, Al Viro, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 465 bytes --]
Hi Linus,
Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
fs/nfs/super.c: In function 'nfs_follow_remote_path':
fs/nfs/super.c:2672: warning: label 'out_mntput' defined but not used
Introduced by commit e9496ff46a20a8592fdc7bdaaf41b45eb808d310 ("fix
mismerge with Trond's stuff (create_mnt_ns() export is gone now)").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* linux-next: origin tree build warning
@ 2009-12-16 3:52 Stephen Rothwell
0 siblings, 0 replies; 38+ messages in thread
From: Stephen Rothwell @ 2009-12-16 3:52 UTC (permalink / raw)
To: Bernhard Walle; +Cc: linux-next, linux-kernel, Andrew Morton, Linus
[-- Attachment #1: Type: text/plain, Size: 407 bytes --]
Hi all,
Today's linux-next build (x86_64 allmodconfig) produced this warning:
usr/include/linux/vt.h:89: userspace cannot call function or variable defined in the kernel
Introduced by commit 5ada918b82399eef3afd6a71e3637697d6bd719f ("vt:
introduce and use vt_kmsg_redirect() function").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* linux-next: origin tree build warning
@ 2009-12-13 23:24 Stephen Rothwell
2009-12-14 7:24 ` Joe Perches
0 siblings, 1 reply; 38+ messages in thread
From: Stephen Rothwell @ 2009-12-13 23:24 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra
Cc: linux-next, linux-kernel, Joe Perches, Linus, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 1655 bytes --]
Hi ,
Today's linux-next build (x86_64 allmodconfig) produced this warning:
arch/x86/mm/mmio-mod.c: In function 'print_pte':
arch/x86/mm/mmio-mod.c:100: warning: too many arguments for format
arch/x86/mm/mmio-mod.c:106: warning: too many arguments for format
arch/x86/mm/mmio-mod.c:110: warning: too many arguments for format
arch/x86/mm/mmio-mod.c: In function 'die_kmmio_nesting_error':
arch/x86/mm/mmio-mod.c:123: warning: too many arguments for format
arch/x86/mm/mmio-mod.c:134: warning: too many arguments for format
arch/x86/mm/mmio-mod.c:136: warning: too many arguments for format
arch/x86/mm/mmio-mod.c: In function 'mmiotrace_ioremap':
arch/x86/mm/mmio-mod.c:286: warning: too many arguments for format
arch/x86/mm/mmio-mod.c: In function 'iounmap_trace_core':
arch/x86/mm/mmio-mod.c:305: warning: too many arguments for format
arch/x86/mm/mmio-mod.c: In function 'clear_trace_list':
arch/x86/mm/mmio-mod.c:367: warning: too many arguments for format
arch/x86/mm/mmio-mod.c: In function 'enter_uniprocessor':
arch/x86/mm/mmio-mod.c:404: warning: too many arguments for format
arch/x86/mm/mmio-mod.c:406: warning: too many arguments for format
arch/x86/mm/mmio-mod.c: In function 'leave_uniprocessor':
arch/x86/mm/mmio-mod.c:426: warning: too many arguments for format
arch/x86/mm/mmio-mod.c:428: warning: too many arguments for format
Caused by commit 3a0340be06a9356eb61f6804107480acbe62c069 ("x86:
mmio-mod.c: Use pr_fmt"). Was this even build tested? The patch doesn't
even match the commit message.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: linux-next: origin tree build warning
2009-12-13 23:24 Stephen Rothwell
@ 2009-12-14 7:24 ` Joe Perches
0 siblings, 0 replies; 38+ messages in thread
From: Joe Perches @ 2009-12-14 7:24 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra,
linux-next, linux-kernel, Linus, Andrew Morton
On Mon, 2009-12-14 at 10:24 +1100, Stephen Rothwell wrote:
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>
> arch/x86/mm/mmio-mod.c: In function 'print_pte':
> Caused by commit 3a0340be06a9356eb61f6804107480acbe62c069 ("x86:
> mmio-mod.c: Use pr_fmt"). Was this even build tested? The patch doesn't
> even match the commit message.
Dunno how that happened, it was tested here
with #define pr_fmt(fmt) "mmiotrace: " fmt
Here's the diff necessary to make it work.
Signed-off-by: Joe Perches <joe@perches.com>
diff --git a/arch/x86/mm/mmio-mod.c b/arch/x86/mm/mmio-mod.c
index 4c765e9..34a3291 100644
--- a/arch/x86/mm/mmio-mod.c
+++ b/arch/x86/mm/mmio-mod.c
@@ -20,7 +20,7 @@
* Derived from the read-mod example from relay-examples by Tom Zanussi.
*/
-#define pr_fmt(fmt) "mmiotrace: "
+#define pr_fmt(fmt) "mmiotrace: " fmt
#define DEBUG 1
^ permalink raw reply [flat|nested] 38+ messages in thread
* linux-next: origin tree build warning
@ 2009-11-29 23:01 Stephen Rothwell
0 siblings, 0 replies; 38+ messages in thread
From: Stephen Rothwell @ 2009-11-29 23:01 UTC (permalink / raw)
To: Len Brown; +Cc: linux-next, linux-kernel, Henrique de Moraes Holschuh
[-- Attachment #1: Type: text/plain, Size: 461 bytes --]
Hi Len,
Today's linux-next build (x86_64 allmodconfig) produced this warning:
drivers/platform/x86/thinkpad_acpi.c:2224: warning: 'tpacpi_hotkey_driver_mask_set' defined but not used
Introduced by commit 8b468c0c85f41c4c55227c17271b4187d8911fb0
("thinkpad-acpi: add internal hotkey event API"). This entered Linus'
tree before 2.6.32-rc1.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* linux-next: origin tree build warning
@ 2009-10-30 3:30 Stephen Rothwell
0 siblings, 0 replies; 38+ messages in thread
From: Stephen Rothwell @ 2009-10-30 3:30 UTC (permalink / raw)
To: Brian King, James E.J. Bottomley
Cc: linux-next, linux-kernel, KOSAKI Motohiro, Andrew Morton, linux-scsi
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
Hi all,
Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
drivers/scsi/ipr.c: In function 'ipr_log_enhanced_dual_ioa_error':
drivers/scsi/ipr.c:1336: warning: ignoring return value of 'strstrip', declared with attribute warn_unused_result
drivers/scsi/ipr.c: In function 'ipr_log_dual_ioa_error':
drivers/scsi/ipr.c:1362: warning: ignoring return value of 'strstrip', declared with attribute warn_unused_result
Exposed by commit 0a1b71b4008d332e57b5605a8228ea7aa96687e8 ("strstrip():
mark as as must_check").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* linux-next: origin tree build warning
@ 2009-10-11 23:56 Stephen Rothwell
0 siblings, 0 replies; 38+ messages in thread
From: Stephen Rothwell @ 2009-10-11 23:56 UTC (permalink / raw)
To: Trond Myklebust; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
Hi Trond,
Today's linux-next build (powerpc ppc64_defconfig) produced these warnings:
fs/nfs/super.c: In function 'nfs_compare_remount_data':
fs/nfs/super.c:1852: warning: passing argument 1 of 'rpc_cmp_addr' from incompatible pointer type
include/linux/sunrpc/clnt.h:254: note: expected 'const struct sockaddr *' but argument is of type 'struct __kernel_sockaddr_storage *'
fs/nfs/super.c:1852: warning: passing argument 2 of 'rpc_cmp_addr' from incompatible pointer type
include/linux/sunrpc/clnt.h:254: note: expected 'const struct sockaddr *' but argument is of type 'struct __kernel_sockaddr_storage *'
Introduced by commit bcd2ea17da6a329a7276cde7286d802f009af332 ("NFS: Fix
port initialisation in nfs_remount()").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* linux-next: origin tree build warning
@ 2009-08-25 0:11 Stephen Rothwell
2009-08-25 2:37 ` David Miller
0 siblings, 1 reply; 38+ messages in thread
From: Stephen Rothwell @ 2009-08-25 0:11 UTC (permalink / raw)
To: David S. Miller; +Cc: linux-next, linux-kernel, netdev
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
Hi Dave,
Today's linux-next build (x86_64 allmodconfig, gcc 4.4.0) produced these
warnings:
net/sched/sch_api.c: In function 'qdisc_watchdog':
net/sched/sch_api.c:460: warning: initialization from incompatible pointer type
net/sched/sch_cbq.c: In function 'cbq_undelay':
net/sched/sch_cbq.c:595: warning: initialization from incompatible pointer type
Introduced by commit ee5f9757ea17759e1ce5503bdae2b07e48e32af9
("pkt_sched: Convert qdisc_watchdog to tasklet_hrtimer").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: linux-next: origin tree build warning
2009-08-25 0:11 Stephen Rothwell
@ 2009-08-25 2:37 ` David Miller
0 siblings, 0 replies; 38+ messages in thread
From: David Miller @ 2009-08-25 2:37 UTC (permalink / raw)
To: sfr; +Cc: linux-next, linux-kernel, netdev
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 25 Aug 2009 10:11:47 +1000
> Today's linux-next build (x86_64 allmodconfig, gcc 4.4.0) produced these
> warnings:
>
> net/sched/sch_api.c: In function 'qdisc_watchdog':
> net/sched/sch_api.c:460: warning: initialization from incompatible pointer type
> net/sched/sch_cbq.c: In function 'cbq_undelay':
> net/sched/sch_cbq.c:595: warning: initialization from incompatible pointer type
>
> Introduced by commit ee5f9757ea17759e1ce5503bdae2b07e48e32af9
> ("pkt_sched: Convert qdisc_watchdog to tasklet_hrtimer").
Thanks I just committed the following to clean that up.
pkt_sched: Fix bogon in tasklet_hrtimer changes.
Reported by Stephen Rothwell, luckily it's harmless:
net/sched/sch_api.c: In function 'qdisc_watchdog':
net/sched/sch_api.c:460: warning: initialization from incompatible pointer type
net/sched/sch_cbq.c: In function 'cbq_undelay':
net/sched/sch_cbq.c:595: warning: initialization from incompatible pointer type
Signed-off-by: David S. Miller <davem@davemloft.net>
---
net/sched/sch_api.c | 2 +-
net/sched/sch_cbq.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index e1c2bf7..92e6f3a 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -458,7 +458,7 @@ EXPORT_SYMBOL(qdisc_warn_nonwc);
static enum hrtimer_restart qdisc_watchdog(struct hrtimer *timer)
{
struct qdisc_watchdog *wd = container_of(timer, struct qdisc_watchdog,
- timer);
+ timer.timer);
wd->qdisc->flags &= ~TCQ_F_THROTTLED;
__netif_schedule(qdisc_root(wd->qdisc));
diff --git a/net/sched/sch_cbq.c b/net/sched/sch_cbq.c
index 81652d6..149b040 100644
--- a/net/sched/sch_cbq.c
+++ b/net/sched/sch_cbq.c
@@ -593,7 +593,7 @@ static psched_tdiff_t cbq_undelay_prio(struct cbq_sched_data *q, int prio,
static enum hrtimer_restart cbq_undelay(struct hrtimer *timer)
{
struct cbq_sched_data *q = container_of(timer, struct cbq_sched_data,
- delay_timer);
+ delay_timer.timer);
struct Qdisc *sch = q->watchdog.qdisc;
psched_time_t now;
psched_tdiff_t delay = 0;
--
1.6.4.1
^ permalink raw reply [flat|nested] 38+ messages in thread
* linux-next: origin tree build warning
@ 2009-06-23 0:36 Stephen Rothwell
0 siblings, 0 replies; 38+ messages in thread
From: Stephen Rothwell @ 2009-06-23 0:36 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-next, linux-kernel, Samuel Ortiz
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
Hi Linus,
Today's linux-next build (x86_64 allmodconfig) produced this warning:
drivers/mfd/ab3100-core.c:563: warning: initialization from incompatible pointer type
Introduced by commit 14fa56917d73d823538151b0429d98211fa439c1 ("mfd: add
U300 AB3100 core support").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* linux-next: origin tree build warning
@ 2009-06-22 1:01 Stephen Rothwell
2009-06-22 3:11 ` FUJITA Tomonori
0 siblings, 1 reply; 38+ messages in thread
From: Stephen Rothwell @ 2009-06-22 1:01 UTC (permalink / raw)
To: Roland Dreier, general; +Cc: linux-next, linux-kernel, FUJITA Tomonori
[-- Attachment #1: Type: text/plain, Size: 795 bytes --]
Hi all,
Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
drivers/infiniband/hw/mthca/mthca_mr.c: In function 'mthca_arbel_write_mtt_seg':
drivers/infiniband/hw/mthca/mthca_mr.c:358: warning: 'dma_sync_single' is deprecated (declared at /scratch/sfr/next/include/linux/dma-mapping.h:113)
drivers/infiniband/hw/mthca/mthca_mr.c: In function 'mthca_arbel_map_phys_fmr':
drivers/infiniband/hw/mthca/mthca_mr.c:810: warning: 'dma_sync_single' is deprecated (declared at /scratch/sfr/next/include/linux/dma-mapping.h:113)
Introduced by commit dbe6f1869188b6e04e38aa861dd198befb08bcd7
("dma-mapping: mark dma_sync_single and dma_sync_sg as deprecated").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: linux-next: origin tree build warning
2009-06-22 1:01 Stephen Rothwell
@ 2009-06-22 3:11 ` FUJITA Tomonori
0 siblings, 0 replies; 38+ messages in thread
From: FUJITA Tomonori @ 2009-06-22 3:11 UTC (permalink / raw)
To: sfr; +Cc: rdreier, general, linux-next, linux-kernel, fujita.tomonori
On Mon, 22 Jun 2009 11:01:13 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
>
> drivers/infiniband/hw/mthca/mthca_mr.c: In function 'mthca_arbel_write_mtt_seg':
> drivers/infiniband/hw/mthca/mthca_mr.c:358: warning: 'dma_sync_single' is deprecated (declared at /scratch/sfr/next/include/linux/dma-mapping.h:113)
> drivers/infiniband/hw/mthca/mthca_mr.c: In function 'mthca_arbel_map_phys_fmr':
> drivers/infiniband/hw/mthca/mthca_mr.c:810: warning: 'dma_sync_single' is deprecated (declared at /scratch/sfr/next/include/linux/dma-mapping.h:113)
>
> Introduced by commit dbe6f1869188b6e04e38aa861dd198befb08bcd7
> ("dma-mapping: mark dma_sync_single and dma_sync_sg as deprecated").
Thanks, here's a fix for this:
http://marc.info/?l=linux-kernel&m=124347325819016&w=2
The patch doesn't change the driver functionally but the driver looks
broken wrt DMA synchronization. I guess that this issue is on Roland's
todo list:
http://marc.info/?l=linux-kernel&m=124354923710600&w=2
^ permalink raw reply [flat|nested] 38+ messages in thread
* linux-next: origin tree build warning
@ 2009-06-19 1:13 Stephen Rothwell
2009-06-19 8:45 ` Kristoffer Ericson
0 siblings, 1 reply; 38+ messages in thread
From: Stephen Rothwell @ 2009-06-19 1:13 UTC (permalink / raw)
To: Linus; +Cc: linux-next, linux-kernel, Kristoffer Ericson, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 486 bytes --]
Hi Linus,
Today's linux-next build (x86_64 allmodconfig) produced this warning:
drivers/video/s1d13xxxfb.c:420: warning: 'bltbit_wait_bitset' defined but not used
drivers/video/s1d13xxxfb.c:463: warning: 'bltbit_fifo_status' defined but not used
Introduced by commit 3ed167af96ed098187ea41353fe02d1af20d38a1 ("fbdev:
s1d13xxxfb: add accelerated bitblt functions").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: linux-next: origin tree build warning
2009-06-19 1:13 Stephen Rothwell
@ 2009-06-19 8:45 ` Kristoffer Ericson
0 siblings, 0 replies; 38+ messages in thread
From: Kristoffer Ericson @ 2009-06-19 8:45 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Linus, linux-next, linux-kernel, Andrew Morton
Greetings,
Hmm, this would be true if you are using the s1d13xxxfb driver without having supported 2D accel (essentially everything not 13506). Atleast
for bltbit_wait_bitset. The bltbit_fifo_status on the other hand is needed later on
for image blitting, which is coming.
The point is basicly this, all s1d13xxxfb cards should get their 2D acceleration
going so until then this is just an annoying but harmless warning.
Hope that answers your comment.
Best wishes
Kristoffer
On Fri, 19 Jun 2009 11:13:59 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Linus,
>
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>
> drivers/video/s1d13xxxfb.c:420: warning: 'bltbit_wait_bitset' defined but not used
> drivers/video/s1d13xxxfb.c:463: warning: 'bltbit_fifo_status' defined but not used
>
> Introduced by commit 3ed167af96ed098187ea41353fe02d1af20d38a1 ("fbdev:
> s1d13xxxfb: add accelerated bitblt functions").
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>
--
Kristoffer Ericson <kristoffer.ericson@gmail.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* linux-next: origin tree build warning
@ 2009-06-19 0:27 Stephen Rothwell
2009-06-19 0:28 ` Stephen Rothwell
0 siblings, 1 reply; 38+ messages in thread
From: Stephen Rothwell @ 2009-06-19 0:27 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
Hi Ted,
Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
In file included from include/trace/ftrace.h:262,
from include/trace/define_trace.h:57,
from include/trace/events/ext4.h:720,
from fs/ext4/super.c:51:
include/trace/events/ext4.h: In function 'ftrace_raw_output_ext4_free_inode':
include/trace/events/ext4.h:12: warning: format '%llu' expects type 'long long unsigned int', but argument 8 has type 'blkcnt_t'
Introduced by commit 9bffad1ed2a003a355ed1b42424a0ae3575275ed ("ext4:
convert instrumentation from markers to tracepoints") now in Linus' tree.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: linux-next: origin tree build warning
2009-06-19 0:27 Stephen Rothwell
@ 2009-06-19 0:28 ` Stephen Rothwell
0 siblings, 0 replies; 38+ messages in thread
From: Stephen Rothwell @ 2009-06-19 0:28 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
On Fri, 19 Jun 2009 10:27:31 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
I get the same warning from an x86_64 allmodconfig build as well.
> In file included from include/trace/ftrace.h:262,
> from include/trace/define_trace.h:57,
> from include/trace/events/ext4.h:720,
> from fs/ext4/super.c:51:
> include/trace/events/ext4.h: In function 'ftrace_raw_output_ext4_free_inode':
> include/trace/events/ext4.h:12: warning: format '%llu' expects type 'long long unsigned int', but argument 8 has type 'blkcnt_t'
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* linux-next: origin tree build warning
@ 2009-04-29 4:49 Stephen Rothwell
0 siblings, 0 replies; 38+ messages in thread
From: Stephen Rothwell @ 2009-04-29 4:49 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-next, LKML
[-- Attachment #1: Type: text/plain, Size: 507 bytes --]
Hi Alan,
Today's linux-next build (x86_64 allmodconfig) produced this warning:
drivers/media/radio/radio-si470x.c: In function 'si470x_fops_release':
drivers/media/radio/radio-si470x.c:1217: warning: label 'unlock' defined but not used
Caused by commit ec5f5bf80501abfe2da2897cfcde8452b545aacb ("radio_si470x:
Fix free memory corruption") which removed the last reference to this
label.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
end of thread, other threads:[~2010-01-27 0:09 UTC | newest]
Thread overview: 38+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-11 1:27 linux-next: origin tree build warning Stephen Rothwell
2009-06-11 10:29 ` [PATCH] x86: memtest: fix compile warning Andreas Herrmann
2009-06-11 11:57 ` [tip:branch?] x86: memtest: add proper typecast for pointer comparison tip-bot for Andreas Herrmann
2009-06-11 14:21 ` [PATCH] x86: memtest: fix compile warning Thomas Gleixner
2009-06-11 14:30 ` H. Peter Anvin
2009-06-11 15:26 ` Andreas Herrmann
2009-06-12 13:11 ` Andreas Herrmann
2009-06-11 17:19 ` Yinghai Lu
2009-06-11 21:05 ` Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2010-01-27 0:09 linux-next: origin tree build warning Stephen Rothwell
2010-01-18 4:05 Stephen Rothwell
2010-01-18 4:14 ` Stephen Rothwell
2010-01-18 4:29 ` Wu, Fengguang
2010-01-18 5:40 ` Stephen Rothwell
2010-01-19 0:12 ` Stephen Rothwell
2010-01-19 21:05 ` Greg KH
2010-01-19 21:11 ` Greg KH
2010-01-19 23:47 ` Stephen Rothwell
[not found] <20100101112914.41bc5f77.sfr@canb.auug.org.au>
2010-01-01 0:34 ` Linus Torvalds
2010-01-01 1:02 ` Stephen Rothwell
2010-01-01 1:16 ` Rafael J. Wysocki
2009-12-17 0:10 Stephen Rothwell
2009-12-16 3:52 Stephen Rothwell
2009-12-13 23:24 Stephen Rothwell
2009-12-14 7:24 ` Joe Perches
2009-11-29 23:01 Stephen Rothwell
2009-10-30 3:30 Stephen Rothwell
2009-10-11 23:56 Stephen Rothwell
2009-08-25 0:11 Stephen Rothwell
2009-08-25 2:37 ` David Miller
2009-06-23 0:36 Stephen Rothwell
2009-06-22 1:01 Stephen Rothwell
2009-06-22 3:11 ` FUJITA Tomonori
2009-06-19 1:13 Stephen Rothwell
2009-06-19 8:45 ` Kristoffer Ericson
2009-06-19 0:27 Stephen Rothwell
2009-06-19 0:28 ` Stephen Rothwell
2009-04-29 4:49 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®