* [PATCH] partitions: fix broken uevent_suppress conversion
@ 2009-06-11 13:14 Heiko Carstens
2009-06-11 13:23 ` Ming Lei
0 siblings, 1 reply; 2+ messages in thread
From: Heiko Carstens @ 2009-06-11 13:14 UTC (permalink / raw)
To: Greg KH, Andrew Morton; +Cc: Ming Lei, linux-kernel
From: Heiko Carstens <heiko.carstens@de.ibm.com>
git commit f67f129e "Driver core: implement uevent suppress in kobject"
contains this chunk for fs/partitions/check.c:
/* suppress uevent if the disk supresses it */
- if (!ddev->uevent_suppress)
+ if (!dev_get_uevent_suppress(pdev))
kobject_uevent(&pdev->kobj, KOBJ_ADD);
However that should have been
- if (!ddev->uevent_suppress)
+ if (!dev_get_uevent_suppress(ddev))
Cc: Ming Lei <tom.leiming@gmail.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
fs/partitions/check.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/fs/partitions/check.c
===================================================================
--- linux-2.6.orig/fs/partitions/check.c
+++ linux-2.6/fs/partitions/check.c
@@ -426,7 +426,7 @@ struct hd_struct *add_partition(struct g
rcu_assign_pointer(ptbl->part[partno], p);
/* suppress uevent if the disk supresses it */
- if (!dev_get_uevent_suppress(pdev))
+ if (!dev_get_uevent_suppress(ddev))
kobject_uevent(&pdev->kobj, KOBJ_ADD);
return p;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] partitions: fix broken uevent_suppress conversion
2009-06-11 13:14 [PATCH] partitions: fix broken uevent_suppress conversion Heiko Carstens
@ 2009-06-11 13:23 ` Ming Lei
0 siblings, 0 replies; 2+ messages in thread
From: Ming Lei @ 2009-06-11 13:23 UTC (permalink / raw)
To: Heiko Carstens; +Cc: Greg KH, Andrew Morton, linux-kernel
2009/6/11 Heiko Carstens <heiko.carstens@de.ibm.com>:
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> git commit f67f129e "Driver core: implement uevent suppress in kobject"
> contains this chunk for fs/partitions/check.c:
>
> /* suppress uevent if the disk supresses it */
> - if (!ddev->uevent_suppress)
> + if (!dev_get_uevent_suppress(pdev))
> kobject_uevent(&pdev->kobj, KOBJ_ADD);
>
> However that should have been
>
> - if (!ddev->uevent_suppress)
> + if (!dev_get_uevent_suppress(ddev))
>
> Cc: Ming Lei <tom.leiming@gmail.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
> fs/partitions/check.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/fs/partitions/check.c
> ===================================================================
> --- linux-2.6.orig/fs/partitions/check.c
> +++ linux-2.6/fs/partitions/check.c
> @@ -426,7 +426,7 @@ struct hd_struct *add_partition(struct g
> rcu_assign_pointer(ptbl->part[partno], p);
>
> /* suppress uevent if the disk supresses it */
> - if (!dev_get_uevent_suppress(pdev))
> + if (!dev_get_uevent_suppress(ddev))
> kobject_uevent(&pdev->kobj, KOBJ_ADD);
>
> return p;
>
Thanks.
Acked-by: Ming Lei <tom.leiming@gmail.com>
--
Lei Ming
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-11 14:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-11 13:14 [PATCH] partitions: fix broken uevent_suppress conversion Heiko Carstens
2009-06-11 13:23 ` Ming Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®