From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: fix unused warning when TCGETX is not defined
Date: Fri, 12 Jun 2009 11:38:30 +0100 [thread overview]
Message-ID: <20090612113830.6c21dfc9@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <8bd0f97a0906120334v2a1bfabr3af883b5cd1ee3a0@mail.gmail.com>
> > If I wasn't so nice I'd just make it and the lack of BOTHER definitions
> > on platforms error. Really there shouldn't be anyone without the features
> > defined ;)
>
> if i knew a lick about these extended tty pieces, i'd look at hooking them up
>
> are these really arch specific ?
The ioctl numbers have to be (although most platforms use the same
values), and the "BOTHER" definition for arbitary baud rates depends on
the format of struct termios - which again varies by architecture. Its
usually the case that CBAUDEX|0 isn't used for anything so we use that
for BOTHER.
Other than the numbering they are not arch specific, so just pick the
constants for the platform.
Alan
next prev parent reply other threads:[~2009-06-12 10:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 10:27 Mike Frysinger
2009-06-12 10:33 ` Alan Cox
2009-06-12 10:34 ` Mike Frysinger
2009-06-12 10:38 ` Alan Cox [this message]
2009-06-12 10:45 ` Mike Frysinger
2009-06-12 10:53 ` Arnd Bergmann
2009-06-12 11:58 ` Alan Cox
2009-06-12 10:47 ` [PATCH] blackfin: update ioctls.h Arnd Bergmann
2009-06-12 10:56 ` [PATCH] Blackfin: sync termios header changes with x86 Mike Frysinger
2009-06-12 11:29 ` Arnd Bergmann
2009-06-12 11:35 ` Mike Frysinger
2009-06-12 21:41 ` Arnd Bergmann
2009-06-13 0:02 ` Mike Frysinger
2009-06-12 11:56 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090612113830.6c21dfc9@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®