From: Mike Frysinger <vapier.adi@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: fix unused warning when TCGETX is not defined
Date: Fri, 12 Jun 2009 06:34:32 -0400 [thread overview]
Message-ID: <8bd0f97a0906120334v2a1bfabr3af883b5cd1ee3a0@mail.gmail.com> (raw)
In-Reply-To: <20090612113320.73e6f7f1@lxorguk.ukuu.org.uk>
On Fri, Jun 12, 2009 at 06:33, Alan Cox wrote:
> On Fri, 12 Jun 2009 06:27:48 -0400 Mike Frysinger wrote:
>> If TCGETX is not defined, we end up with this warning:
>> drivers/char/tty_ioctl.c: In function ‘tty_mode_ioctl’:
>> drivers/char/tty_ioctl.c:950: warning: unused variable ‘ktermx’
>>
>> Since the variable is only used in one case statement, push it down to
>> the local case scope.
>
> If I wasn't so nice I'd just make it and the lack of BOTHER definitions
> on platforms error. Really there shouldn't be anyone without the features
> defined ;)
if i knew a lick about these extended tty pieces, i'd look at hooking them up
are these really arch specific ?
-mike
next prev parent reply other threads:[~2009-06-12 10:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 10:27 Mike Frysinger
2009-06-12 10:33 ` Alan Cox
2009-06-12 10:34 ` Mike Frysinger [this message]
2009-06-12 10:38 ` Alan Cox
2009-06-12 10:45 ` Mike Frysinger
2009-06-12 10:53 ` Arnd Bergmann
2009-06-12 11:58 ` Alan Cox
2009-06-12 10:47 ` [PATCH] blackfin: update ioctls.h Arnd Bergmann
2009-06-12 10:56 ` [PATCH] Blackfin: sync termios header changes with x86 Mike Frysinger
2009-06-12 11:29 ` Arnd Bergmann
2009-06-12 11:35 ` Mike Frysinger
2009-06-12 21:41 ` Arnd Bergmann
2009-06-13 0:02 ` Mike Frysinger
2009-06-12 11:56 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0906120334v2a1bfabr3af883b5cd1ee3a0@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®