From: Andreas Mohr <andi@lisas.de>
To: Ed Tomlinson <edt@aei.ca>
Cc: Borislav Petkov <petkovbb@googlemail.com>,
Peter Feuerer <peter@piie.net>,
akpm@linux-foundation.org, Andreas Mohr <andi@lisas.de>,
Len Brown <len.brown@intel.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH/RFC] Acer Aspire One fan control resume fix, improvements
Date: Tue, 16 Jun 2009 22:57:47 +0200 [thread overview]
Message-ID: <20090616205747.GA6356@rhlx01.hs-esslingen.de> (raw)
In-Reply-To: <200906160747.04094.edt@aei.ca>
Hi,
On Tue, Jun 16, 2009 at 07:47:02AM -0400, Ed Tomlinson wrote:
> Please add this to the kernel now. I have been using version of this on my wife's
> acer since I installed linux on it. Its been doing its job as adverstised. This is not
> a core feature - its a driver. It works. Why not add it?
Seconded. Better not wait 18 months this time.
This being said, I'm unfortunately _still_ experiencing the resume issue (unexpected fan
state) from time to time after resume. Really needs more investigation
to get that fixed somehow, eventually.
Also, the pre_suspend_kernelmode variable is superfluous indeed, as mentioned this
can be simplified.
Atom emergency shutdown works fine on my machine (blocked fan sometimes,
going tick-tick-tick on boot etc., nice way to test this BIOS feature ;),
thus given this extra protection I believe the driver can be committed as is
anyway, nevermind any remaining driver issues which _might_ perhaps
eventually still exist.
Andreas Mohr
next prev parent reply other threads:[~2009-06-16 20:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 9:10 [PATCH] Request driver inclusion - acer aspire one fan control Peter Feuerer
2009-06-03 12:14 ` Borislav Petkov
2009-06-03 21:24 ` Peter Feuerer
2009-06-04 8:02 ` Andrew Morton
2009-06-04 10:38 ` Borislav Petkov
2009-06-04 19:11 ` Peter Feuerer
2009-06-07 12:03 ` Andreas Mohr
2009-06-12 14:37 ` [PATCH/RFC] Acer Aspire One fan control resume fix, improvements Andreas Mohr
2009-06-12 15:37 ` Borislav Petkov
2009-06-15 17:15 ` Peter Feuerer
2009-06-16 6:01 ` Borislav Petkov
2009-06-16 11:47 ` Ed Tomlinson
2009-06-16 20:57 ` Andreas Mohr [this message]
2009-06-16 22:14 ` [PATCH] Request driver inclusion - acer aspire one fan control Peter Feuerer
2009-06-16 22:34 ` Randy Dunlap
2009-06-17 12:20 ` Andreas Mohr
2009-06-18 7:10 ` Peter Feuerer
2009-06-18 10:29 ` Borislav Petkov
2009-06-18 10:55 ` Peter Feuerer
2009-06-18 11:42 ` Borislav Petkov
2009-06-18 11:49 ` Peter Feuerer
2009-06-18 12:45 ` Borislav Petkov
2009-06-18 13:25 ` Andreas Mohr
2009-06-19 17:01 ` [PATCH v0.5.10] " Peter Feuerer
2009-06-18 13:31 ` [PATCH] " Peter Feuerer
2009-06-18 13:54 ` Andreas Mohr
2009-06-18 14:05 ` Peter Feuerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090616205747.GA6356@rhlx01.hs-esslingen.de \
--to=andi@lisas.de \
--cc=akpm@linux-foundation.org \
--cc=edt@aei.ca \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=peter@piie.net \
--cc=petkovbb@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®