Re: [PATCH] Request driver inclusion - acer aspire one fan control

[Borislav Petkov <petkovbb@googlemail.com>]

Hi,

On Thu, Jun 18, 2009 at 12:55 PM, Peter Feuerer<peter@piie.net> wrote:
>>>> Didn't someone argue that pre_suspend_kernelmode was unnecessary?
>>>> It's still in there. (could be submitted together with the
>>>> Kconfig ACPI depends ;)
>>>
>>> Actually I think pre_suspend_kernelmode is needed, so it won't be
>>> dropped.
>>
>> and it is needed, because...?
>
> It's needed because we do now a clean revert to bios mode before we suspend.
> And after resume we have to switch to kernelmode again, if the driver was in
> kernelmode before suspend. So we need to keep track of in what state the
> driver was before suspending. That's what's this variable is for.

You've got that state in the 'kernelmode' variable. See full comment:
http://marc.info/?l=linux-kernel&m=124482114200865

>>> I'll add the ACPI dependency to Kconfig and submit the patch to lkml
>>> and directly to Linus, as Len doesn't seem to react?! - Boris what do
>>> you think? I mean, even if there's a problem with suspend / resume,
>>> this can also be fixed after the merge window, while all those release
>>> candidates are done.
>>
>> Nope, this has to be fixed before submission. The merge window is open,
>> I think, until mid next week so there's plenty of time.
>
> I'll be only there until Sunday evening. I'm going to be on business trip
> starting on Monday (and returning probably at Saturday). But I'll do my best
> to figure out the problem.
>
> I wasn't able to reproduce the suspend / resume problem Andreas has with
> acerhdf 0.5.9 yesterday and the day before. Do you also have the problem,
> that acerhdf is reading sometimes an unexpected Fan state after resuming?

Will look into it on the weekend.

-- 
Regards/Gruss,
Boris