From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Rongrong Cao <rrcao@ambarella.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
trivial@kernel.org
Subject: Re: [PATCH] sound dapm: fix check for external widgets bug (based on linux-2.6.30.1)
Date: Tue, 7 Jul 2009 19:39:48 +0100 [thread overview]
Message-ID: <20090707183948.GA6681@sirena.org.uk> (raw)
In-Reply-To: <90B0CE4312136749B97EBEAF5764F87403C8F2D3@ambarella-ex.ambarella.net>
On Mon, Jul 06, 2009 at 05:55:27AM -0700, Rongrong Cao wrote:
> This patch is based on linux-2.6.30.1
> In SOC DAPM layer of SOUND subsystem, when add signal route (in the function snd_soc_dapm_add_route() ),
> the original code has wrong logic when dapm layer check each widget whether an external one.
This looks like it's probably a good fix but doesn't apply against
current ASoC since there have been some changes in this area. The
latest ASoC code can be found here:
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.32
Could you please regenerate (and ideally retest too) against that?
It may be useful to take a look at Documentation/SubmittingPatches for
details on how patches should normally be submitted.
prev parent reply other threads:[~2009-07-07 18:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 12:55 Rongrong Cao
2009-07-07 18:39 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090707183948.GA6681@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rrcao@ambarella.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®