[PATCH] sound dapm: fix check for external widgets bug (based on linux-2.6.30.1)

[PATCH] sound dapm: fix check for external widgets bug (based on linux-2.6.30.1)

[Rongrong Cao]

From: Rongrong Cao rrcao@ambarella.com

This patch is based on linux-2.6.30.1
In SOC DAPM layer of SOUND subsystem, when add signal route (in the function snd_soc_dapm_add_route() ), 
the original code has wrong logic when dapm layer check each widget whether an external one.

---------------------------------------------------------------------------------------------------------

--- linux-2.6.30.1/sound/soc/soc-dapm.c.orig    2009-07-06 19:48:43.000000000 +0800
+++ linux-2.6.30.1/sound/soc/soc-dapm.c 2009-07-06 19:03:15.000000000 +0800
@@ -983,8 +983,8 @@ static int snd_soc_dapm_add_route(struct
        if (wsink->id == snd_soc_dapm_input) {
                if (wsource->id == snd_soc_dapm_micbias ||
                        wsource->id == snd_soc_dapm_mic ||
-                       wsink->id == snd_soc_dapm_line ||
-                       wsink->id == snd_soc_dapm_output)
+                       wsource->id == snd_soc_dapm_line ||
+                       wsource->id == snd_soc_dapm_output)
                        wsink->ext = 1;
        }
        if (wsource->id == snd_soc_dapm_output) {

---------------------------------------------------------------------------------------------------------

Signed-off-by: Rongrong Cao rrcao@ambarella.com

********************
Best regards!
Allen (Rongrong) Cao
Ambarella Shanghai Ltd.
Tel:   (86-21) 50942311
Fax:  (86-21) 50942321

Re: [PATCH] sound dapm: fix check for external widgets bug (based on linux-2.6.30.1)

[Mark Brown]

On Mon, Jul 06, 2009 at 05:55:27AM -0700, Rongrong Cao wrote:

> This patch is based on linux-2.6.30.1
> In SOC DAPM layer of SOUND subsystem, when add signal route (in the function snd_soc_dapm_add_route() ), 
> the original code has wrong logic when dapm layer check each widget whether an external one.

This looks like it's probably a good fix but doesn't apply against
current ASoC since there have been some changes in this area.  The
latest ASoC code can be found here:

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.32

Could you please regenerate (and ideally retest too) against that?

It may be useful to take a look at Documentation/SubmittingPatches for
details on how patches should normally be submitted.