* [PATCH 05/06] Fix compilation warning for arch/x86/kernel/apm_32.c
@ 2009-07-15 2:20 Subrata Modak
2009-07-18 14:13 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Subrata Modak @ 2009-07-15 2:20 UTC (permalink / raw)
To: linux-laptop, Stephen Rothwell
Cc: Sachin P Sant, Ingo Molnar, David Howells, Ingo Molnar,
Subrata Modak, Balbir Singh, LKML
Following fix is inspired by David Howells fix few days back:
http://lkml.org/lkml/2009/7/9/109,
Signed-off-by: Subrata Modak<subrata@linux.vnet.ibm.com>,
---
--- a/arch/x86/kernel/apm_32.c 2009-06-15 07:50:51.000000000 +0530
+++ b/arch/x86/kernel/apm_32.c 2009-07-15 06:43:59.000000000 +0530
@@ -811,7 +811,7 @@ static int apm_do_idle(void)
u8 ret = 0;
int idled = 0;
int polling;
- int err;
+ int uninitialized_var(err);
polling = !!(current_thread_info()->status & TS_POLLING);
if (polling) {
---
Regards--
Subrata
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 05/06] Fix compilation warning for arch/x86/kernel/apm_32.c
2009-07-15 2:20 [PATCH 05/06] Fix compilation warning for arch/x86/kernel/apm_32.c Subrata Modak
@ 2009-07-18 14:13 ` Ingo Molnar
2009-07-21 2:33 ` Subrata Modak
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2009-07-18 14:13 UTC (permalink / raw)
To: Subrata Modak
Cc: linux-laptop, Stephen Rothwell, Sachin P Sant, Ingo Molnar,
David Howells, Balbir Singh, LKML
* Subrata Modak <subrata@linux.vnet.ibm.com> wrote:
> Following fix is inspired by David Howells fix few days back:
> http://lkml.org/lkml/2009/7/9/109,
>
> Signed-off-by: Subrata Modak<subrata@linux.vnet.ibm.com>,
> ---
>
> --- a/arch/x86/kernel/apm_32.c 2009-06-15 07:50:51.000000000 +0530
> +++ b/arch/x86/kernel/apm_32.c 2009-07-15 06:43:59.000000000 +0530
> @@ -811,7 +811,7 @@ static int apm_do_idle(void)
> u8 ret = 0;
> int idled = 0;
> int polling;
> - int err;
> + int uninitialized_var(err);
Please dont use uninitialized_var() as it's dangerous - in something
as performance-uncritical as this we should initialize it to 0 and
mention it in the changelog that this works around a GCC false
positive warning.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 05/06] Fix compilation warning for arch/x86/kernel/apm_32.c
2009-07-18 14:13 ` Ingo Molnar
@ 2009-07-21 2:33 ` Subrata Modak
0 siblings, 0 replies; 3+ messages in thread
From: Subrata Modak @ 2009-07-21 2:33 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-laptop, Stephen Rothwell, Sachin P Sant, Ingo Molnar,
David Howells, Balbir Singh, LKML
On Sat, 2009-07-18 at 16:13 +0200, Ingo Molnar wrote:
> * Subrata Modak <subrata@linux.vnet.ibm.com> wrote:
>
> > Following fix is inspired by David Howells fix few days back:
> > http://lkml.org/lkml/2009/7/9/109,
> >
> > Signed-off-by: Subrata Modak<subrata@linux.vnet.ibm.com>,
> > ---
> >
> > --- a/arch/x86/kernel/apm_32.c 2009-06-15 07:50:51.000000000 +0530
> > +++ b/arch/x86/kernel/apm_32.c 2009-07-15 06:43:59.000000000 +0530
> > @@ -811,7 +811,7 @@ static int apm_do_idle(void)
> > u8 ret = 0;
> > int idled = 0;
> > int polling;
> > - int err;
> > + int uninitialized_var(err);
>
> Please dont use uninitialized_var() as it's dangerous - in something
> as performance-uncritical as this we should initialize it to 0 and
> mention it in the changelog that this works around a GCC false
> positive warning.
Sure. Resending as you suggested.
Regards--
Subrata
>
> Thanks,
>
> Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-21 2:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-15 2:20 [PATCH 05/06] Fix compilation warning for arch/x86/kernel/apm_32.c Subrata Modak
2009-07-18 14:13 ` Ingo Molnar
2009-07-21 2:33 ` Subrata Modak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome