* "floppy: fix hibernation" causes error on resume from ram
@ 2009-07-18 18:06 Alan Jenkins
2009-07-18 18:19 ` Ondrej Zary
0 siblings, 1 reply; 3+ messages in thread
From: Alan Jenkins @ 2009-07-18 18:06 UTC (permalink / raw)
To: Ondrej Zary
Cc: Ingo Molnar, Pavel Machek, Jens Axboe, linux-kernel, Kernel Testers List
Thanks for the hibernation fix! Until recently I thought my floppy was
just dead. Unfortunately, the fix seems to cause me errors on resume
from suspend to ram. The floppy works fine afterwards, it just spams
the log.
On 2.6.30 there were no errors, and the floppy survived suspend-to-ram.
So I guess the quick fix would be to only do the fix-up on resume from
hibernation, and not suspend-to-ram.
Thanks
Alan
Jul 18 15:27:23 alan-desktop kernel: [34795.256645]
Jul 18 15:27:23 alan-desktop kernel: [34795.256647] floppy driver state
Jul 18 15:27:23 alan-desktop kernel: [34795.256649] -------------------
Jul 18 15:27:23 alan-desktop kernel: [34795.256652] now=4305315874 last
interrupt=4303125175 diff=2190699 last called handler=ffffffffa00a64d0
Jul 18 15:27:23 alan-desktop kernel: [34795.256655] timeout_message=lock fdc
Jul 18 15:27:23 alan-desktop kernel: [34795.256657] last output bytes:
Jul 18 15:27:23 alan-desktop kernel: [34795.256659] 8 80 4295201276
Jul 18 15:27:23 alan-desktop kernel: [34795.256662] 8 80 4295201276
Jul 18 15:27:23 alan-desktop kernel: [34795.256664] 8 80 4295201276
Jul 18 15:27:23 alan-desktop kernel: [34795.256666] 8 80 4295201276
Jul 18 15:27:23 alan-desktop kernel: [34795.256668] 8 80 4297332499
Jul 18 15:27:23 alan-desktop kernel: [34795.256669] 8 80 4297332499
Jul 18 15:27:23 alan-desktop kernel: [34795.256671] 8 80 4297332499
Jul 18 15:27:23 alan-desktop kernel: [34795.256673] 8 80 4297332499
Jul 18 15:27:23 alan-desktop kernel: [34795.256675] 8 80 4298652310
Jul 18 15:27:23 alan-desktop kernel: [34795.256677] 8 80 4298652310
Jul 18 15:27:23 alan-desktop kernel: [34795.256679] 8 80 4298652310
Jul 18 15:27:23 alan-desktop kernel: [34795.256681] 8 80 4298652310
Jul 18 15:27:23 alan-desktop kernel: [34795.256683] 8 80 4299614961
Jul 18 15:27:23 alan-desktop kernel: [34795.256685] 8 80 4299614961
Jul 18 15:27:23 alan-desktop kernel: [34795.256687] 8 80 4299614961
Jul 18 15:27:23 alan-desktop kernel: [34795.256689] 8 80 4299614961
Jul 18 15:27:23 alan-desktop kernel: [34795.256691] 8 80 4303125175
Jul 18 15:27:23 alan-desktop kernel: [34795.256693] 8 80 4303125175
Jul 18 15:27:23 alan-desktop kernel: [34795.256695] 8 80 4303125175
Jul 18 15:27:23 alan-desktop kernel: [34795.256697] 8 80 4303125175
Jul 18 15:27:23 alan-desktop kernel: [34795.256699] last result at
4303125175
Jul 18 15:27:23 alan-desktop kernel: [34795.256701] last redo_fd_request
at 4303125175
Jul 18 15:27:23 alan-desktop kernel: [34795.256703]
Jul 18 15:27:23 alan-desktop kernel: [34795.256709] status=0
Jul 18 15:27:23 alan-desktop kernel: [34795.256711] fdc_busy=1
Jul 18 15:27:23 alan-desktop kernel: [34795.256713]
do_floppy=ffffffffa00a64d0
Jul 18 15:27:23 alan-desktop kernel: [34795.256715] cont=ffffffffa00ad8c0
Jul 18 15:27:23 alan-desktop kernel: [34795.256717] current_req=(null)
Jul 18 15:27:23 alan-desktop kernel: [34795.256719] command_status=-1
Jul 18 15:27:23 alan-desktop kernel: [34795.256720]
Jul 18 15:27:23 alan-desktop kernel: [34795.256829] floppy0: floppy
timeout called
Jul 18 15:27:23 alan-desktop kernel: [34795.259455] Restarting tasks ...
done.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: "floppy: fix hibernation" causes error on resume from ram
2009-07-18 18:06 "floppy: fix hibernation" causes error on resume from ram Alan Jenkins
@ 2009-07-18 18:19 ` Ondrej Zary
2009-07-18 18:27 ` Alan Jenkins
0 siblings, 1 reply; 3+ messages in thread
From: Ondrej Zary @ 2009-07-18 18:19 UTC (permalink / raw)
To: Alan Jenkins
Cc: Ingo Molnar, Pavel Machek, Jens Axboe, linux-kernel, Kernel Testers List
On Saturday 18 July 2009 20:06:54 Alan Jenkins wrote:
> Thanks for the hibernation fix! Until recently I thought my floppy was
> just dead. Unfortunately, the fix seems to cause me errors on resume
> from suspend to ram. The floppy works fine afterwards, it just spams
> the log.
>
> On 2.6.30 there were no errors, and the floppy survived suspend-to-ram.
> So I guess the quick fix would be to only do the fix-up on resume from
> hibernation, and not suspend-to-ram.
My machine has no suspend-to-RAM so I haven't tested it.
That would be probably the correct fix. But how to do it? AFAIK, there's only
one suspend() and one resume() for everything. And that looks very wrong as
resume-from-hibernation is fundamentally different from resume-from-RAM.
>
> Thanks
> Alan
>
> Jul 18 15:27:23 alan-desktop kernel: [34795.256645]
> Jul 18 15:27:23 alan-desktop kernel: [34795.256647] floppy driver state
> Jul 18 15:27:23 alan-desktop kernel: [34795.256649] -------------------
> Jul 18 15:27:23 alan-desktop kernel: [34795.256652] now=4305315874 last
> interrupt=4303125175 diff=2190699 last called handler=ffffffffa00a64d0
> Jul 18 15:27:23 alan-desktop kernel: [34795.256655] timeout_message=lock
> fdc Jul 18 15:27:23 alan-desktop kernel: [34795.256657] last output bytes:
> Jul 18 15:27:23 alan-desktop kernel: [34795.256659] 8 80 4295201276 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256662] 8 80 4295201276 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256664] 8 80 4295201276 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256666] 8 80 4295201276 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256668] 8 80 4297332499 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256669] 8 80 4297332499 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256671] 8 80 4297332499 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256673] 8 80 4297332499 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256675] 8 80 4298652310 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256677] 8 80 4298652310 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256679] 8 80 4298652310 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256681] 8 80 4298652310 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256683] 8 80 4299614961 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256685] 8 80 4299614961 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256687] 8 80 4299614961 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256689] 8 80 4299614961 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256691] 8 80 4303125175 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256693] 8 80 4303125175 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256695] 8 80 4303125175 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256697] 8 80 4303125175 Jul 18
> 15:27:23 alan-desktop kernel: [34795.256699] last result at 4303125175
> Jul 18 15:27:23 alan-desktop kernel: [34795.256701] last redo_fd_request
> at 4303125175
> Jul 18 15:27:23 alan-desktop kernel: [34795.256703]
> Jul 18 15:27:23 alan-desktop kernel: [34795.256709] status=0
> Jul 18 15:27:23 alan-desktop kernel: [34795.256711] fdc_busy=1
> Jul 18 15:27:23 alan-desktop kernel: [34795.256713]
> do_floppy=ffffffffa00a64d0
> Jul 18 15:27:23 alan-desktop kernel: [34795.256715] cont=ffffffffa00ad8c0
> Jul 18 15:27:23 alan-desktop kernel: [34795.256717] current_req=(null)
> Jul 18 15:27:23 alan-desktop kernel: [34795.256719] command_status=-1
> Jul 18 15:27:23 alan-desktop kernel: [34795.256720]
> Jul 18 15:27:23 alan-desktop kernel: [34795.256829] floppy0: floppy
> timeout called
> Jul 18 15:27:23 alan-desktop kernel: [34795.259455] Restarting tasks ...
> done.
--
Ondrej Zary
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: "floppy: fix hibernation" causes error on resume from ram
2009-07-18 18:19 ` Ondrej Zary
@ 2009-07-18 18:27 ` Alan Jenkins
0 siblings, 0 replies; 3+ messages in thread
From: Alan Jenkins @ 2009-07-18 18:27 UTC (permalink / raw)
To: Ondrej Zary
Cc: Ingo Molnar, Pavel Machek, Jens Axboe, linux-kernel, Kernel Testers List
Ondrej Zary wrote:
> On Saturday 18 July 2009 20:06:54 Alan Jenkins wrote:
>
>> Thanks for the hibernation fix! Until recently I thought my floppy was
>> just dead. Unfortunately, the fix seems to cause me errors on resume
>> from suspend to ram. The floppy works fine afterwards, it just spams
>> the log.
>>
>> On 2.6.30 there were no errors, and the floppy survived suspend-to-ram.
>> So I guess the quick fix would be to only do the fix-up on resume from
>> hibernation, and not suspend-to-ram.
>>
>
> My machine has no suspend-to-RAM so I haven't tested it.
>
> That would be probably the correct fix. But how to do it? AFAIK, there's only
> one suspend() and one resume() for everything. And that looks very wrong as
> resume-from-hibernation is fundamentally different from resume-from-RAM.
>
Ok. Looking at drivers/base/platform.c, we want "restore()". I guess I
can do the patch myself :-).
Thanks
Alan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-18 18:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-18 18:06 "floppy: fix hibernation" causes error on resume from ram Alan Jenkins
2009-07-18 18:19 ` Ondrej Zary
2009-07-18 18:27 ` Alan Jenkins
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®