From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Adrian Hunter <adrian.hunter@nokia.com>
Cc: arun c <arun.edarath@gmail.com>, Julia Lawall <julia@diku.dk>,
"Lavinen Jarkko (Nokia-D/Helsinki)" <jarkko.lavinen@nokia.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 9/10] drivers/mmc: Move a dereference below a NULL test
Date: Mon, 20 Jul 2009 13:47:36 +0100 [thread overview]
Message-ID: <20090720134736.605f86d1@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4A64665B.9000504@nokia.com>
> It is not a "NULL check" it is an assertion, which can be compiled out.
> On some platforms BUG is implemented as a null dereference anyway
> e.g. on ARM it is *(int *)0 = 0;
It's a bogus check because the
struct mmc_omap_host *host = slot->host;
has already been executed before you check for slot == NULL
prev parent reply other threads:[~2009-07-20 12:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-19 15:30 Julia Lawall
2009-07-20 8:01 ` Adrian Hunter
2009-07-20 12:33 ` arun c
2009-07-20 12:43 ` Adrian Hunter
2009-07-20 12:47 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090720134736.605f86d1@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=adrian.hunter@nokia.com \
--cc=arun.edarath@gmail.com \
--cc=jarkko.lavinen@nokia.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®