From: Julia Lawall <julia@diku.dk>
To: jarkko.lavinen@nokia.com, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH 9/10] drivers/mmc: Move a dereference below a NULL test
Date: Sun, 19 Jul 2009 17:30:26 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0907191729580.16542@ask.diku.dk> (raw)
From: Julia Lawall <julia@diku.dk>
If the NULL test is necessary, then the dereference should be moved below
the NULL test.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
expression E,E1;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E=E1
when != i
BUG_ON (E == NULL||
- i
+ E->fld
== NULL || ...);
+ i = E->fld;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/mmc/host/omap.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index e7a331d..89281ab 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -255,11 +255,12 @@ static void mmc_omap_slot_release_work(struct work_struct *work)
static void mmc_omap_release_slot(struct mmc_omap_slot *slot, int clk_enabled)
{
- struct mmc_omap_host *host = slot->host;
+ struct mmc_omap_host *host;
unsigned long flags;
int i;
- BUG_ON(slot == NULL || host->mmc == NULL);
+ BUG_ON(slot == NULL || slot->host->mmc == NULL);
+ host = slot->host;
if (clk_enabled)
/* Keeps clock running for at least 8 cycles on valid freq */
next reply other threads:[~2009-07-19 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-19 15:30 Julia Lawall [this message]
2009-07-20 8:01 ` Adrian Hunter
2009-07-20 12:33 ` arun c
2009-07-20 12:43 ` Adrian Hunter
2009-07-20 12:47 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0907191729580.16542@ask.diku.dk \
--to=julia@diku.dk \
--cc=jarkko.lavinen@nokia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®