mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Stoyan Gaydarov <sgayda2@uiuc.edu>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	stanley.miao@windriver.com, rmk+kernel@arm.linux.org.uk,
	madhu.cr@ti.com, felipe.balbi@nokia.com
Subject: Re: [PATCH] missing mutex unlock
Date: Thu, 30 Jul 2009 15:00:52 +0400	[thread overview]
Message-ID: <20090730110048.GA24094@2ka.mipt.ru> (raw)
In-Reply-To: <1248947838-20087-1-git-send-email-sgayda2@uiuc.edu>

On Thu, Jul 30, 2009 at 04:57:18AM -0500, Stoyan Gaydarov (sgayda2@uiuc.edu) wrote:
> This was found using a semantic patch, more info can be found at:
> http://www.emn.fr/x-info/coccinelle/
> 
> Signed-off-by: Stoyan Gaydarov <sgayda2@uiuc.edu>

Yup, that's correct.
Ack, thank you.

Andrew, please apply.

> ---
>  drivers/w1/masters/omap_hdq.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index a7e3b70..0d92969 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -687,6 +687,7 @@ static int omap_hdq_remove(struct platform_device *pdev)
>  
>  	if (hdq_data->hdq_usecount) {
>  		dev_dbg(&pdev->dev, "removed when use count is not zero\n");
> +		mutex_unlock(&hdq_data->hdq_mutex);
>  		return -EBUSY;
>  	}
>  
> -- 
> 1.6.3.3

      reply	other threads:[~2009-07-30 11:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-30  9:57 Stoyan Gaydarov
2009-07-30 11:00 ` Evgeniy Polyakov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090730110048.GA24094@2ka.mipt.ru \
    --to=johnpol@2ka.mipt.ru \
    --cc=akpm@linux-foundation.org \
    --cc=felipe.balbi@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madhu.cr@ti.com \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=sgayda2@uiuc.edu \
    --cc=stanley.miao@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®