* [PATCH] missing mutex unlock
@ 2009-07-30 9:57 Stoyan Gaydarov
2009-07-30 11:00 ` Evgeniy Polyakov
0 siblings, 1 reply; 2+ messages in thread
From: Stoyan Gaydarov @ 2009-07-30 9:57 UTC (permalink / raw)
To: linux-kernel
Cc: Stoyan Gaydarov, johnpol, akpm, stanley.miao, rmk+kernel,
madhu.cr, felipe.balbi
This was found using a semantic patch, more info can be found at:
http://www.emn.fr/x-info/coccinelle/
Signed-off-by: Stoyan Gaydarov <sgayda2@uiuc.edu>
---
drivers/w1/masters/omap_hdq.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
index a7e3b70..0d92969 100644
--- a/drivers/w1/masters/omap_hdq.c
+++ b/drivers/w1/masters/omap_hdq.c
@@ -687,6 +687,7 @@ static int omap_hdq_remove(struct platform_device *pdev)
if (hdq_data->hdq_usecount) {
dev_dbg(&pdev->dev, "removed when use count is not zero\n");
+ mutex_unlock(&hdq_data->hdq_mutex);
return -EBUSY;
}
--
1.6.3.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] missing mutex unlock
2009-07-30 9:57 [PATCH] missing mutex unlock Stoyan Gaydarov
@ 2009-07-30 11:00 ` Evgeniy Polyakov
0 siblings, 0 replies; 2+ messages in thread
From: Evgeniy Polyakov @ 2009-07-30 11:00 UTC (permalink / raw)
To: Stoyan Gaydarov
Cc: linux-kernel, akpm, stanley.miao, rmk+kernel, madhu.cr, felipe.balbi
On Thu, Jul 30, 2009 at 04:57:18AM -0500, Stoyan Gaydarov (sgayda2@uiuc.edu) wrote:
> This was found using a semantic patch, more info can be found at:
> http://www.emn.fr/x-info/coccinelle/
>
> Signed-off-by: Stoyan Gaydarov <sgayda2@uiuc.edu>
Yup, that's correct.
Ack, thank you.
Andrew, please apply.
> ---
> drivers/w1/masters/omap_hdq.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index a7e3b70..0d92969 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -687,6 +687,7 @@ static int omap_hdq_remove(struct platform_device *pdev)
>
> if (hdq_data->hdq_usecount) {
> dev_dbg(&pdev->dev, "removed when use count is not zero\n");
> + mutex_unlock(&hdq_data->hdq_mutex);
> return -EBUSY;
> }
>
> --
> 1.6.3.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-30 11:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-30 9:57 [PATCH] missing mutex unlock Stoyan Gaydarov
2009-07-30 11:00 ` Evgeniy Polyakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®