Re: [PATCH] ctags usability fix

[Amerigo Wang <xiyou.wangcong@gmail.com>]

On Sat, Aug 01, 2009 at 10:13:13AM +0200, Stefani Seibold wrote:
>Hi,
>
>the tag file generated by the tags.sh script has some issue.
>
>First:
>  The identifier-list miss the 
>  DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL
>  special handling, which can result in a wrong tag, not to jump to the
>  right variable definition or function implementation.
> 
>Second:
>  It makes no real sense to include function prototypes and external and 
>  forward variable declarations, because jumping to a tag will sometimes
>  go to this and not to the real definition and implementation. The information
>  about the declaration is still there at the definition and implementation 
>  place.
>
>So this patch make it lot easier to navigate through the kernel source 
>tree using vi.


Looks reasonable. Thanks.

Acked-by: WANG Cong <xiyou.wangcong@gmail.com>

Sam?


>
>Greetings,
>Stefani
>
> tags.sh |    3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>Signed-off-by: Stefani Seibold <stefani@seibold.net>
>
>--- linux-2.6.30.orig/scripts/tags.sh	2009-06-10 05:05:27.000000000 +0200
>+++ linux-2.6.30/scripts/tags.sh	2009-08-01 09:46:56.000000000 +0200
>@@ -101,7 +101,8 @@
> 	-I ____cacheline_aligned_in_smp                         \
> 	-I ____cacheline_internodealigned_in_smp                \
> 	-I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL                      \
>-	--extra=+f --c-kinds=+px                                \
>+	-I DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL \
>+	--extra=+f --c-kinds=-px                                \
> 	--regex-asm='/^ENTRY\(([^)]*)\).*/\1/'                  \
> 	--regex-c='/^SYSCALL_DEFINE[[:digit:]]?\(([^,)]*).*/sys_\1/'
> 
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/