From: Gleb Natapov <gleb@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
suresh.b.siddha@intel.com, tglx@linutronix.de,
sheng@linux.intel.com, avi@redhat.com,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/apic] x86/apic: Enable x2APIC without interrupt remapping under KVM
Date: Wed, 5 Aug 2009 15:26:08 +0300 [thread overview]
Message-ID: <20090805122608.GJ4764@redhat.com> (raw)
In-Reply-To: <20090805121923.GI4764@redhat.com>
On Wed, Aug 05, 2009 at 03:19:23PM +0300, Gleb Natapov wrote:
> On Wed, Aug 05, 2009 at 02:16:21PM +0200, Ingo Molnar wrote:
> >
> > * Gleb Natapov <gleb@redhat.com> wrote:
> >
> > > +static inline void x2apic_force_phys()
> > > +{
> > > +}
> >
> > Sigh. Have you tested this patche and have you looked at the
> > resultig compiler output?
> >
> I haven't looked and compiler output. What is wrong with it?
> Is defining this function as #define would be batter?
>
Actually I made it a define initially and tested with it. Later I change
it to be inline and apparently tested only with x2apic enabled. I see the
problem now. Do you want it to be define or properly defined empty inline
function like any other function in this code?
--
Gleb.
next prev parent reply other threads:[~2009-08-05 12:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 12:24 [PATCH] enable " Gleb Natapov
2009-08-04 13:15 ` [tip:x86/apic] x86/apic: Enable " tip-bot for Gleb Natapov
2009-08-04 13:37 ` Ingo Molnar
2009-08-04 16:57 ` Gleb Natapov
2009-08-05 12:16 ` Ingo Molnar
2009-08-05 12:19 ` Gleb Natapov
2009-08-05 12:26 ` Gleb Natapov [this message]
2009-08-05 10:55 ` tip-bot for Gleb Natapov
2009-08-05 12:30 ` tip-bot for Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090805122608.GJ4764@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=sheng@linux.intel.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome