From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Anuj Aggarwal <anuj.aggarwal@ti.com>
Cc: lrg@slimlogic.co.uk, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/8] Regulator: Added board-dependent code for TPS65023
Date: Sat, 8 Aug 2009 08:45:24 +0100 [thread overview]
Message-ID: <20090808074523.GA5005@sirena.org.uk> (raw)
In-Reply-To: <1249658970-11100-1-git-send-email-anuj.aggarwal@ti.com>
On Fri, Aug 07, 2009 at 08:59:30PM +0530, Anuj Aggarwal wrote:
> + },
> + .num_consumer_supplies = 1,
> + .consumer_supplies = &tps65023_core_consumers,
> + },
This is all OK but as a style thing it's better to use ARRAY_SIZE() for
the number of consumers even if there's just one since that way if
someone adds another consumer they don't need to remember to adjust the
array length.
prev parent reply other threads:[~2009-08-08 7:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-07 15:29 Anuj Aggarwal
2009-08-08 7:45 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090808074523.GA5005@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=anuj.aggarwal@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®