* [PATCH 7/8] Regulator: Added board-dependent code for TPS65023
@ 2009-08-07 15:29 Anuj Aggarwal
2009-08-08 7:45 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Anuj Aggarwal @ 2009-08-07 15:29 UTC (permalink / raw)
To: broonie, lrg, linux-omap, linux-kernel; +Cc: Anuj Aggarwal
Added OMAP35x specific code for TPS65023 in board-omap35x-pmic.c
Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
---
arch/arm/mach-omap2/board-omap35x-pmic.c | 93 +++++++++++++++++++++++++++++-
1 files changed, 92 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-omap35x-pmic.c b/arch/arm/mach-omap2/board-omap35x-pmic.c
index 11db66f..0bf47fd 100644
--- a/arch/arm/mach-omap2/board-omap35x-pmic.c
+++ b/arch/arm/mach-omap2/board-omap35x-pmic.c
@@ -30,6 +30,96 @@
/*
* Definitions specific to TPS65023
*/
+#if defined(CONFIG_OMAP3EVM_TPS65023)
+/* MPU voltage regulator of DCDC type */
+struct regulator_consumer_supply tps65023_mpu_consumers = {
+ .supply = "vdd1",
+};
+
+/* CORE voltage regulator of DCDC type */
+struct regulator_consumer_supply tps65023_core_consumers = {
+ .supply = "vdd2",
+};
+
+/* SRAM/MEM/WKUP_BG voltage regulator of DCDC type */
+struct regulator_consumer_supply tps65023_vdds_consumers = {
+ .supply = "vdds",
+};
+
+/* DPLL voltage regulator of LDO type */
+struct regulator_consumer_supply tps65023_dpll_consumers = {
+ .supply = "dpll",
+};
+
+/* MMC voltage regulator of LDO type */
+struct regulator_consumer_supply tps65023_mmc_consumers = {
+ .supply = "mmc",
+};
+
+struct regulator_init_data tps65023_regulator_data[] = {
+ {
+ .constraints = {
+ .min_uV = 800000,
+ .max_uV = 1600000,
+ .valid_ops_mask = (REGULATOR_CHANGE_VOLTAGE |
+ REGULATOR_CHANGE_STATUS),
+ .boot_on = 1,
+ },
+ .num_consumer_supplies = 1,
+ .consumer_supplies = &tps65023_mpu_consumers,
+ },
+ {
+ .constraints = {
+ .min_uV = 1800000,
+ .max_uV = 3300000,
+ .valid_ops_mask = REGULATOR_CHANGE_STATUS,
+ .boot_on = 1,
+ },
+ .num_consumer_supplies = 1,
+ .consumer_supplies = &tps65023_core_consumers,
+ },
+ {
+ .constraints = {
+ .min_uV = 1800000,
+ .max_uV = 3300000,
+ .valid_ops_mask = REGULATOR_CHANGE_STATUS,
+ .boot_on = 1,
+ },
+ .num_consumer_supplies = 1,
+ .consumer_supplies = &tps65023_vdds_consumers,
+ },
+ {
+ .constraints = {
+ .min_uV = 1000000,
+ .max_uV = 3150000,
+ .valid_ops_mask = (REGULATOR_CHANGE_VOLTAGE |
+ REGULATOR_CHANGE_STATUS),
+ .boot_on = 1,
+ },
+ .num_consumer_supplies = 1,
+ .consumer_supplies = &tps65023_dpll_consumers,
+ },
+ {
+ .constraints = {
+ .min_uV = 1050000,
+ .max_uV = 3300000,
+ .valid_ops_mask = (REGULATOR_CHANGE_VOLTAGE |
+ REGULATOR_CHANGE_STATUS),
+ .boot_on = 1,
+ },
+ .num_consumer_supplies = 1,
+ .consumer_supplies = &tps65023_mmc_consumers,
+ },
+};
+
+static struct i2c_board_info __initdata board_tps65023_instances[] = {
+ {
+ I2C_BOARD_INFO("tps65023", 0x48),
+ .flags = I2C_CLIENT_WAKE,
+ .platform_data = &tps65023_regulator_data[0],
+ },
+};
+#endif
/*
* Definitions specific to TPS65073
@@ -109,7 +199,8 @@ int oma35x_pmic_init(void)
#endif
#if defined(CONFIG_OMAP3EVM_TPS65023)
- /* do stuff specific to TPS65023 */
+ omap_register_i2c_bus(1, 400, board_tps65023_instances,
+ ARRAY_SIZE(board_tps65023_instances));
#endif
#if defined(CONFIG_OMAP3EVM_TPS65073)
--
1.6.2.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 7/8] Regulator: Added board-dependent code for TPS65023
2009-08-07 15:29 [PATCH 7/8] Regulator: Added board-dependent code for TPS65023 Anuj Aggarwal
@ 2009-08-08 7:45 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2009-08-08 7:45 UTC (permalink / raw)
To: Anuj Aggarwal; +Cc: lrg, linux-omap, linux-kernel
On Fri, Aug 07, 2009 at 08:59:30PM +0530, Anuj Aggarwal wrote:
> + },
> + .num_consumer_supplies = 1,
> + .consumer_supplies = &tps65023_core_consumers,
> + },
This is all OK but as a style thing it's better to use ARRAY_SIZE() for
the number of consumers even if there's just one since that way if
someone adds another consumer they don't need to remember to adjust the
array length.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-08 7:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-07 15:29 [PATCH 7/8] Regulator: Added board-dependent code for TPS65023 Anuj Aggarwal
2009-08-08 7:45 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®