From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: reget cfg_new in case reuse/move irq_desc
Date: Sat, 8 Aug 2009 17:02:42 +0200 [thread overview]
Message-ID: <20090808150242.GA28892@elte.hu> (raw)
In-Reply-To: <4A785AB6.3020803@kernel.org>
* Yinghai Lu <yinghai@kernel.org> wrote:
> when irq_desc is moved, we need to make sure to use right cfg_new
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
> ---
> arch/x86/kernel/apic/io_apic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6/arch/x86/kernel/apic/io_apic.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/apic/io_apic.c
> +++ linux-2.6/arch/x86/kernel/apic/io_apic.c
> @@ -3153,6 +3153,7 @@ unsigned int create_irq_nr(unsigned int
> continue;
>
> desc_new = move_irq_desc(desc_new, node);
> + cfg_new = desc_new->chip_data;
>
i suspect we need this for .31? Did you see any actual bug due to
this? (if yes, how did it look like?)
Ingo
next prev parent reply other threads:[~2009-08-08 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 15:58 Yinghai Lu
2009-08-08 15:02 ` Ingo Molnar [this message]
2009-09-27 7:21 Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090808150242.GA28892@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome