Re: [PATCH 1/5] drivers/mfd: Add Freescale MC13783 driver

[Sascha Hauer <s.hauer@pengutronix.de>]

Hi Mark,

On Tue, Aug 11, 2009 at 11:12:40AM +0100, Mark Brown wrote:
> On Tue, Aug 11, 2009 at 11:07:43AM +0200, Sascha Hauer wrote:
> 
> > +/*
> > + * Register a client device.  This is non-fatal since there is no need to
> > + * fail the entire device init due to a single platform device failing.
> > + */
> > +static void mc13783_client_dev_register(struct mc13783 *mc13783,
> > +				       const char *name,
> > +				       struct platform_device **pdev)
> 
> Some of this code is looking distinctly familiar :)

Indeed, I added a 'based on' to the header.

> 
> > +#define	SW_SW1A		0
> > +#define	SW_SW1B		1
> 
> This and the other defines following look like they should probably be
> namespaced.

Ok.

Thanks for reviewing. I addressed these comments and the comments you made
to the other patches. I'll delay reposting a bit in case others have
comments aswell.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |