mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.arm.linux.org.uk,
	Daniel Ribeiro <drwyrm@gmail.com>
Subject: Re: [RFC] Freescale MC13783 PMIC support
Date: Tue, 11 Aug 2009 13:28:42 +0100	[thread overview]
Message-ID: <20090811122842.GG24947@sirena.org.uk> (raw)
In-Reply-To: <20090811140500.2678b289.ospite@studenti.unina.it>

On Tue, Aug 11, 2009 at 02:05:00PM +0200, Antonio Ospite wrote:
> Sascha Hauer <s.hauer@pengutronix.de> wrote:

> There is a driver queued for inclusion in 2.6.31 for the PCAP2
> PMIC, which is quite similar to MC13783. This driver uses the irq_chip
> mechanism to expose the PMIC IRQs to be used as general IRQs in
> sub-devices drivers (which you call client-devices AFAICS). Also, it

Use of the generic IRQ infrastructure in I2C/SPI MFDs is a bit dodgy at
this point - it can be persuaded to work but genirq really doesn't
support it properly since it wants to run with interrupts disabled but
you want interrupts for these slower buses.  It's likely to get resolved
but right now it's safer to work outside the framework in order to avoid
surprises.

> passed all the reviews so maybe you can give it a look to take some
> other solution already accepted by reviewers, like passing sub-devices
> via platform data (some of the phones which use PCAP2 don't have
> touchscreen, for instance), generalize the driver so to handle multiple

There's also the wm831x drivers which do all the subdevice stuff via the
MFD core and are prepared for a transition to genirq once devices like
this are actively supported by it.

> PMICs in one system (quite unlikely scenario?), read actual pressure

It's vanishingly unlikely that you'd see two Atlases in one system - you
might see two PMICs but not two primary PMICs with stuff like battery
chargers on them.

  reply	other threads:[~2009-08-11 12:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-11  9:07 Sascha Hauer
2009-08-11  9:07 ` [PATCH 1/5] drivers/mfd: Add Freescale MC13783 driver Sascha Hauer
2009-08-11  9:07   ` [PATCH 2/5] [input] add mc13783 touchscreen driver Sascha Hauer
2009-08-11  9:07     ` [PATCH 3/5] [hwmon] add Freescale MC13783 adc driver Sascha Hauer
2009-08-11  9:07       ` [PATCH 4/5] [RTC] Add Freescale MC13783 RTC driver Sascha Hauer
2009-08-11  9:07         ` [PATCH 5/5] [regulator] Add a Freescale MC13783 regulator driver Sascha Hauer
2009-08-11 10:19           ` Mark Brown
2009-08-12  2:15     ` [PATCH 2/5] [input] add mc13783 touchscreen driver Dmitry Torokhov
2009-08-12 11:10       ` Sascha Hauer
2009-08-12 11:16         ` Mark Brown
2009-08-12 11:34           ` Sascha Hauer
2009-08-12 16:01         ` Dmitry Torokhov
2009-08-11 10:12   ` [PATCH 1/5] drivers/mfd: Add Freescale MC13783 driver Mark Brown
2009-08-11 11:38     ` Sascha Hauer
2009-08-11 10:15   ` Mark Brown
2009-08-11 12:05 ` [RFC] Freescale MC13783 PMIC support Antonio Ospite
2009-08-11 12:28   ` Mark Brown [this message]
2009-08-15  1:17     ` Daniel Ribeiro
2009-08-11 13:57   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090811122842.GG24947@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=drwyrm@gmail.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ospite@studenti.unina.it \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®