* [PATCH] usbhid/hid-code.c: local function should be static
@ 2009-08-17 22:37 H Hartley Sweeten
2009-08-18 11:58 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2009-08-17 22:37 UTC (permalink / raw)
To: jkosina; +Cc: linux-usb, Linux Kernel
__usbhid_submit_report() is a local function wrapped by the exported
symbol usbhid_submit_report(). As such, it should be static.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Jiri Kosina <jkosina@suse.cz>
---
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index 3c1fcb7..1f31a9e 100644
--- a/drivers/hid/usbhid/hid-core.c
+++ b/drivers/hid/usbhid/hid-core.c
@@ -489,7 +489,8 @@ static void hid_ctrl(struct urb *urb)
wake_up(&usbhid->wait);
}
-void __usbhid_submit_report(struct hid_device *hid, struct hid_report *report, unsigned char dir)
+static void __usbhid_submit_report(struct hid_device *hid, struct hid_report *report,
+ unsigned char dir)
{
int head;
struct usbhid_device *usbhid = hid->driver_data;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] usbhid/hid-code.c: local function should be static
2009-08-17 22:37 [PATCH] usbhid/hid-code.c: local function should be static H Hartley Sweeten
@ 2009-08-18 11:58 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2009-08-18 11:58 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: linux-usb, Linux Kernel
On Mon, 17 Aug 2009, H Hartley Sweeten wrote:
> __usbhid_submit_report() is a local function wrapped by the exported
> symbol usbhid_submit_report(). As such, it should be static.
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-18 11:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-17 22:37 [PATCH] usbhid/hid-code.c: local function should be static H Hartley Sweeten
2009-08-18 11:58 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®