From: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
To: linux-kernel@vger.kernel.org
Cc: linux-scsi@vger.kernel.org, akpm@linux-foundation.org,
axboe@kernel.dk, andrew.patterson@hp.com,
mikem@c18-ss-1-lb.cnet.com, scameron@beardog.cce.hp.com
Subject: [cciss: PATCH 06/17] Rearrange logical drive sysfs code to make the "changing a disk" path work.
Date: Thu, 20 Aug 2009 10:18:13 -0500 [thread overview]
Message-ID: <20090820151813.22833.6732.stgit@beardog.cce.hp.com> (raw)
In-Reply-To: <20090820151648.22833.14168.stgit@beardog.cce.hp.com>
Rearrange logical drive sysfs code to make the "changing a disk" path work.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
---
drivers/block/cciss.c | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 4f9ef49..557b958 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -1915,9 +1915,10 @@ static int cciss_add_gendisk(ctlr_info_t *h, __u32 lunid, int controller_node)
}
}
h->drv[drv_index].LunID = lunid;
- if (cciss_create_ld_sysfs_entry(h, drv_index))
- goto err_free_disk;
-
+ if (h->drv[drv_index].dev == NULL) {
+ if (cciss_create_ld_sysfs_entry(h, drv_index))
+ goto err_free_disk;
+ }
/* Don't need to mark this busy because nobody */
/* else knows about this disk yet to contend */
/* for access to it. */
@@ -2144,8 +2145,10 @@ static int deregister_disk(ctlr_info_t *h, int drv_index,
*/
if (h->gendisk[0] != disk) {
struct request_queue *q = disk->queue;
- if (disk->flags & GENHD_FL_UP)
+ if (disk->flags & GENHD_FL_UP) {
+ cciss_destroy_ld_sysfs_entry(h, drv_index);
del_gendisk(disk);
+ }
if (q) {
blk_cleanup_queue(q);
/* Set drv->queue to NULL so that we do not try
@@ -2189,7 +2192,6 @@ static int deregister_disk(ctlr_info_t *h, int drv_index,
* indicate that this element of the drive
* array is free.
*/
- cciss_destroy_ld_sysfs_entry(h, drv_index);
if (clear_all) {
/* check to see if it was the last disk */
@@ -4307,15 +4309,13 @@ static void __devexit cciss_remove_one(struct pci_dev *pdev)
if (disk) {
struct request_queue *q = disk->queue;
- if (disk->flags & GENHD_FL_UP)
+ if (disk->flags & GENHD_FL_UP) {
+ cciss_destroy_ld_sysfs_entry(hba[i], j);
del_gendisk(disk);
+ }
if (q)
blk_cleanup_queue(q);
}
- if (hba[i]->drv[j].dev != NULL &&
- (j == 0 || hba[i]->drv[j].raid_level != -1))
- cciss_destroy_ld_sysfs_entry(hba[i], j);
-
}
#ifdef CONFIG_CISS_SCSI_TAPE
next prev parent reply other threads:[~2009-08-20 15:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 15:17 [cciss: PATCH 00/17] fix scan_thread, sysfs stuff, LUN addressing problem Stephen M. Cameron
2009-08-20 15:17 ` [cciss: PATCH 01/17] Remove sysfs entries for logical drives on driver cleanup Stephen M. Cameron
2009-08-20 15:17 ` [cciss: PATCH 02/17] Use one scan thread per controller and fix hang during rmmod Stephen M. Cameron
2009-08-20 15:17 ` [cciss: PATCH 03/17] Allow triggering of rescan of logical drive topology via sysfs entry Stephen M. Cameron
2009-08-20 15:18 ` [cciss: PATCH 04/17] Remove some unused code in rebuild_lun_table() Stephen M. Cameron
2009-08-20 15:18 ` [cciss: PATCH 05/17] Dynamically allocate struct device for each logical drive as needed Stephen M. Cameron
2009-08-20 15:18 ` Stephen M. Cameron [this message]
2009-08-20 15:18 ` [cciss: PATCH 07/17] Handle failure of blk_init_queue gracefully in cciss_add_disk Stephen M. Cameron
2009-08-20 15:18 ` [cciss: PATCH 08/17] Handle cases when cciss_add_disk fails Stephen M. Cameron
2009-08-20 15:18 ` [cciss: PATCH 09/17] Handle special case for sysfs attributes of the first logical drive Stephen M. Cameron
2009-08-20 15:18 ` [cciss: PATCH 10/17] Clear all sysfs-exposed data for deleted logical drives Stephen M. Cameron
2009-08-20 15:18 ` [cciss: PATCH 11/17] Fix usage_count check in rebuild_lun_table when triggered via sysfs Stephen M. Cameron
2009-08-20 15:18 ` [cciss: PATCH 12/17] Fix excessive gendisk freeing bug on driver unload Stephen M. Cameron
2009-08-20 15:18 ` [cciss: PATCH 13/17] Silence noisy per-disk messages output by cciss_read_capacity Stephen M. Cameron
2009-08-20 15:18 ` [cciss: PATCH 14/17] Preserve all 8 bytes of LUN ID for logical drives Stephen M. Cameron
2009-08-20 15:18 ` [cciss: PATCH 15/17] Add lunid attribute to each logical drive in /sys Stephen M. Cameron
2009-08-20 15:19 ` [cciss: PATCH 16/17] Add a "raid_level" " Stephen M. Cameron
2009-08-20 15:19 ` [cciss: PATCH 17/17] Add usage_count " Stephen M. Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090820151813.22833.6732.stgit@beardog.cce.hp.com \
--to=scameron@beardog.cce.hp.com \
--cc=akpm@linux-foundation.org \
--cc=andrew.patterson@hp.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mikem@c18-ss-1-lb.cnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome