* [PATCH mmotm] vfs: optimize touch_time too fix
@ 2009-08-31 15:03 Hugh Dickins
2009-08-31 15:10 ` Christoph Hellwig
2009-08-31 16:41 ` Andi Kleen
0 siblings, 2 replies; 3+ messages in thread
From: Hugh Dickins @ 2009-08-31 15:03 UTC (permalink / raw)
To: Andrew Morton
Cc: Andi Kleen, Dave Hansen, Christoph Hellwig, Valerie Aurora,
Al Viro, linux-kernel
Recent mmotms give me WARNING: at fs/namespace.c:612 mntput_no_expire()+...
when unmounting: __mntput()'s WARN_ON(count_mnt_writers(mnt)).
That's because vfs-optimize-touch_time-too.patch inverted the sense
of mnt_want_write_file(), which is error-returning, not a boolean.
Presumably filetime updates went missing too, but I didn't notice those.
Signed-off-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>
---
fs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- mmotm/fs/inode.c 2009-08-28 10:07:56.000000000 +0100
+++ linux/fs/inode.c 2009-08-31 14:08:24.000000000 +0100
@@ -1481,7 +1481,7 @@ void file_update_time(struct file *file)
return;
/* Finally allowed to write? Takes lock. */
- if (!mnt_want_write_file(file))
+ if (mnt_want_write_file(file))
return;
/* Only change inode inside the lock region */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH mmotm] vfs: optimize touch_time too fix
2009-08-31 15:03 [PATCH mmotm] vfs: optimize touch_time too fix Hugh Dickins
@ 2009-08-31 15:10 ` Christoph Hellwig
2009-08-31 16:41 ` Andi Kleen
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2009-08-31 15:10 UTC (permalink / raw)
To: Hugh Dickins
Cc: Andrew Morton, Andi Kleen, Dave Hansen, Christoph Hellwig,
Valerie Aurora, Al Viro, linux-kernel
On Mon, Aug 31, 2009 at 04:03:02PM +0100, Hugh Dickins wrote:
> Recent mmotms give me WARNING: at fs/namespace.c:612 mntput_no_expire()+...
> when unmounting: __mntput()'s WARN_ON(count_mnt_writers(mnt)).
>
> That's because vfs-optimize-touch_time-too.patch inverted the sense
> of mnt_want_write_file(), which is error-returning, not a boolean.
>
> Presumably filetime updates went missing too, but I didn't notice those.
>
> Signed-off-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>
> ---
>
> fs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- mmotm/fs/inode.c 2009-08-28 10:07:56.000000000 +0100
> +++ linux/fs/inode.c 2009-08-31 14:08:24.000000000 +0100
> @@ -1481,7 +1481,7 @@ void file_update_time(struct file *file)
> return;
>
> /* Finally allowed to write? Takes lock. */
> - if (!mnt_want_write_file(file))
> + if (mnt_want_write_file(file))
Eeek. having an error return from a function called want_foo is rather
strange. It's a name the implies a bolean return value.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH mmotm] vfs: optimize touch_time too fix
2009-08-31 15:03 [PATCH mmotm] vfs: optimize touch_time too fix Hugh Dickins
2009-08-31 15:10 ` Christoph Hellwig
@ 2009-08-31 16:41 ` Andi Kleen
1 sibling, 0 replies; 3+ messages in thread
From: Andi Kleen @ 2009-08-31 16:41 UTC (permalink / raw)
To: Hugh Dickins
Cc: Andrew Morton, Dave Hansen, Christoph Hellwig, Valerie Aurora,
Al Viro, linux-kernel
Hugh Dickins wrote:
> Recent mmotms give me WARNING: at fs/namespace.c:612 mntput_no_expire()+...
> when unmounting: __mntput()'s WARN_ON(count_mnt_writers(mnt)).
Oops. Strange I ran my system quite some time with the patches
and didn't see these warnings.
Thanks Hugh.
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-31 16:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-31 15:03 [PATCH mmotm] vfs: optimize touch_time too fix Hugh Dickins
2009-08-31 15:10 ` Christoph Hellwig
2009-08-31 16:41 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome