mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	James Bottomley <James.Bottomley@suse.de>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Helge Deller <deller@gmx.de>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] fix "no member named 'sect_attrs' of strcut module"
Date: Fri, 4 Sep 2009 07:04:28 +0200	[thread overview]
Message-ID: <20090904050428.GB8382@elte.hu> (raw)
In-Reply-To: <1252036108-24221-1-git-send-email-wuzhangjin@gmail.com>


* Wu Zhangjin <wuzhangjin@gmail.com> wrote:

> From: Wu Zhangjin <wuzhangjin@gmail.com>
> 
> The commit(1b364bf438cf337a3818aee77d68c0713f3e1fc4, "module: workaround
> duplicate section names") introduced a condition to avoid null pointer
> reference:
> 
> -       add_notes_attrs(mod, hdr->e_shnum, secstrings, sechdrs);
> +       if (mod->sect_attrs)
> +               add_notes_attrs(mod, hdr->e_shnum, secstrings, sechdrs);
> 
> but sect_attrs is only defined when CONFIG_KALLSYMS enabled, so this
> patch is need to fix the following error:
> 
> error: 'struct module' has no member named 'sect_attrs'
> 
> Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>

This has been fixed already, see this upstream fix:

  ea6bff3: modules: Fix build error in the !CONFIG_KALLSYMS case

	Ingo

      reply	other threads:[~2009-09-04  5:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-04  3:48 Wu Zhangjin
2009-09-04  5:04 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090904050428.GB8382@elte.hu \
    --to=mingo@elte.hu \
    --cc=James.Bottomley@suse.de \
    --cc=deller@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@linux-foundation.org \
    --cc=wuzhangjin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®