From: Wu Zhangjin <wuzhangjin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: James Bottomley <James.Bottomley@suse.de>,
Rusty Russell <rusty@rustcorp.com.au>,
Helge Deller <deller@gmx.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Wu Zhangjin <wuzhangjin@gmail.com>
Subject: [PATCH] fix "no member named 'sect_attrs' of strcut module"
Date: Fri, 4 Sep 2009 11:48:28 +0800 [thread overview]
Message-ID: <1252036108-24221-1-git-send-email-wuzhangjin@gmail.com> (raw)
From: Wu Zhangjin <wuzhangjin@gmail.com>
The commit(1b364bf438cf337a3818aee77d68c0713f3e1fc4, "module: workaround
duplicate section names") introduced a condition to avoid null pointer
reference:
- add_notes_attrs(mod, hdr->e_shnum, secstrings, sechdrs);
+ if (mod->sect_attrs)
+ add_notes_attrs(mod, hdr->e_shnum, secstrings, sechdrs);
but sect_attrs is only defined when CONFIG_KALLSYMS enabled, so this
patch is need to fix the following error:
error: 'struct module' has no member named 'sect_attrs'
Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
---
kernel/module.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/module.c b/kernel/module.c
index eccb561..b4016d1 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2355,8 +2355,10 @@ static noinline struct module *load_module(void __user *umod,
if (err < 0)
goto unlink;
add_sect_attrs(mod, hdr->e_shnum, secstrings, sechdrs);
+#ifdef CONFIG_KALLSYMS
if (mod->sect_attrs)
add_notes_attrs(mod, hdr->e_shnum, secstrings, sechdrs);
+#endif
/* Get rid of temporary copy */
vfree(hdr);
--
1.6.2.1
next reply other threads:[~2009-09-04 3:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 3:48 Wu Zhangjin [this message]
2009-09-04 5:04 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252036108-24221-1-git-send-email-wuzhangjin@gmail.com \
--to=wuzhangjin@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®