Re: [Uclinux-dist-devel] [PATCH] input/keyboard: add ADP5588 QWERTYI2C Keyboard Input device driver

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Wed, Sep 16, 2009 at 12:25:56AM -0400, Mike Frysinger wrote:
> On Wed, Sep 16, 2009 at 00:18, Song, Barry wrote:
> >From: Mike Frysinger
> >>On Tue, Sep 15, 2009 at 23:49, Barry Song wrote:
> >>> Even though CONFIG_GENERIC_HARDIRQS is almost always "y", in case
> >>> CONFIG_GENERIC_HARDIRQS is "n" not "y", threaded_irq will become
> >>> original irq, drivers will not work. So is it necessary to check the
> >>> dependence of GENERIC_HARDIRQS while using threaded_irq?
> >>
> >>when is GENERIC_HARDIRQS not "y" ?  a quick check shows only s390/m68k
> >>dont set it to "y" in their arch Kconfig ?  s390 isnt going to use any
> >>of these drivers, and m68k will eventually update (m68knommu already
> >>has !?).
> >
> > SPARC32 is "n" too. I am not caring about only these several drivers. I just want to find whether that can be a generic problem while using threaded_irq in any driver.
> 
> SPARC32 too is dead, so dont sweat it.  it's safe to assume
> GENERIC_HARDIRQS is "y" in the code we write like these input drivers.

I agree here.

-- 
Dmitry