From: Mike Frysinger <vapier.adi@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Robin Getz <rgetz@blackfin.uclinux.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
Michael Hennerich <michael.hennerich@analog.com>,
Bryan Wu <cooloney@kernel.org>
Subject: Re: [PATCH] input/keyboard: add ADP5588 QWERTY I2C Keyboard Input device driver
Date: Tue, 15 Sep 2009 07:19:14 -0400 [thread overview]
Message-ID: <8bd0f97a0909150419p1048bfe9j243fa30a0581b198@mail.gmail.com> (raw)
In-Reply-To: <20090915062050.GB10232@core.coreip.homeip.net>
On Tue, Sep 15, 2009 at 02:20, Dmitry Torokhov wrote:
> On Mon, Sep 14, 2009 at 06:18:39PM -0400, Mike Frysinger wrote:
>> +static int __devexit adp5588_remove(struct i2c_client *client)
>> +{
>> + struct adp5588_kpad *kpad = dev_get_drvdata(&client->dev);
>> +
>> + adp5588_write(client, CFG, 0);
>> + free_irq(client->irq, kpad);
>
> cancel_work_sync() is missing. Could you try the updated version below?
i dont think i have any adp5588 hardware. Robin: do we have any in
Norwood ? otherwise, it'll have to wait for Michael to get back to
double check.
> BTW, maybe you shoudl convert to threaded IRQs here?
yes, after your suggestion for the previous driver, we've been looking
at all our input drivers to convert to threaded IRQs. do we need to
convert all of them before acceptance, or can we merge now and post an
updated patch after ?
-mike
next prev parent reply other threads:[~2009-09-15 11:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 22:18 Mike Frysinger
2009-09-15 6:20 ` Dmitry Torokhov
2009-09-15 11:19 ` Mike Frysinger [this message]
2009-09-15 16:26 ` Dmitry Torokhov
2009-09-15 16:46 ` Mike Frysinger
2009-09-15 17:17 ` Dmitry Torokhov
2009-09-16 3:49 ` Barry Song
2009-09-16 4:03 ` Mike Frysinger
2009-09-16 4:18 ` [Uclinux-dist-devel] [PATCH] input/keyboard: add ADP5588 QWERTYI2C " Song, Barry
2009-09-16 4:25 ` Mike Frysinger
2009-09-16 4:49 ` Dmitry Torokhov
2009-09-16 21:07 ` [PATCH] input/keyboard: add ADP5588 QWERTY I2C " Robin Getz
2009-09-16 0:49 ` [PATCH v2] " Mike Frysinger
2009-09-16 5:02 ` Dmitry Torokhov
2009-09-16 12:55 ` [Uclinux-dist-devel] " Mike Frysinger
2009-09-16 16:33 ` Dmitry Torokhov
2009-09-16 18:20 ` [PATCH v3] " Mike Frysinger
2009-09-18 5:42 ` Dmitry Torokhov
2009-09-21 16:45 ` [Uclinux-dist-devel] [PATCH v2] " Mike Frysinger
2009-09-21 16:55 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0909150419p1048bfe9j243fa30a0581b198@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=cooloney@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=rgetz@blackfin.uclinux.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®