Re: [RFC/PATCH] SLQB: Mark the allocator as broken PowerPC and S390

[Heiko Carstens <heiko.carstens@de.ibm.com>]

On Wed, Sep 16, 2009 at 10:01:08AM +0300, Pekka Enberg wrote:
> On Wed, 16 Sep 2009, Pekka Enberg wrote:
> > > The SLQB allocator is known to be broken on certain PowerPC and S390
> > > configurations. Disable the allocator in Kconfig for those architectures
> > > until the issues are resolved.

Looks ok to me. I'll debug s390 when time permits.

> > >  init/Kconfig |    1 +
> > >  1 files changed, 1 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/init/Kconfig b/init/Kconfig
> > > index c0d8a47..aaeddeb 100644
> > > --- a/init/Kconfig
> > > +++ b/init/Kconfig
> > > @@ -1033,6 +1033,7 @@ config SLUB
> > >  
> > >  config SLQB
> > >  	bool "SLQB (Queued allocator)"
> > > +	depends on !PPC && !S390
> > >  	help
> > >  	  SLQB is a proposed new slab allocator.
> > >  
> 
> On Tue, 2009-09-15 at 23:55 -0700, David Rientjes wrote:
> > I think this should be (!PPC && !S390) || EXPERIMENTAL so that it can 
> > still be enabled for debugging and development.
> 
> Everybody enables EXPERIMENTAL so that seems pointless. Developers can
> hack Kconfig locally, no?

Exactly.