Re: [PATCH] media: video: pwc: Use kernel's simple_strtol()

["Andrey Panin" <pazke@centrinvest.ru>]

On 259, 09 16, 2009 at 02:42:27PM +0300, Andy Shevchenko wrote:
> From: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
> 
> Change own implementation of atoi() by simple_strtol(x, NULL, 10).

Why did you keep the wrapper itself then ?


> Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
> ---
>  drivers/media/video/pwc/pwc-if.c |   13 +++----------
>  1 files changed, 3 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/media/video/pwc/pwc-if.c b/drivers/media/video/pwc/pwc-if.c
> index f976df4..cb995c6 100644
> --- a/drivers/media/video/pwc/pwc-if.c
> +++ b/drivers/media/video/pwc/pwc-if.c
> @@ -68,6 +68,7 @@
>  #endif
>  #include <linux/vmalloc.h>
>  #include <asm/io.h>
> +#include <linux/kernel.h>		/* simple_strtol() */
>  
>  #include "pwc.h"
>  #include "pwc-kiara.h"
> @@ -1916,17 +1917,9 @@ disconnect_out:
>  	unlock_kernel();
>  }
>  
> -/* *grunt* We have to do atoi ourselves :-( */
> -static int pwc_atoi(const char *s)
> +static inline int pwc_atoi(const char *s)
>  {
> -	int k = 0;
> -
> -	k = 0;
> -	while (*s != '\0' && *s >= '0' && *s <= '9') {
> -		k = 10 * k + (*s - '0');
> -		s++;
> -	}
> -	return k;
> +	return (int)simple_strtol(s, NULL, 10);
>  }