From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Subject: Re: [PATCH v2] media: video: pwc: Use kernel's simple_strtol()
Date: Wed, 16 Sep 2009 15:43:55 +0300 [thread overview]
Message-ID: <84144f020909160543s38daa8ebs989b9da09802d681@mail.gmail.com> (raw)
In-Reply-To: <1253103989-25635-1-git-send-email-andy.shevchenko@gmail.com>
On Wed, Sep 16, 2009 at 3:26 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> @@ -2078,13 +2066,13 @@ static int __init usb_pwc_init(void)
> }
> else {
> /* No type or serial number specified, just a number. */
> - device_hint[i].device_node = pwc_atoi(s);
> + device_hint[i].device_node = (int)simple_strtol(s, NULL, 10);
What's with all the casting to int?
next prev parent reply other threads:[~2009-09-16 12:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 11:42 [PATCH] " Andy Shevchenko
2009-09-16 12:05 ` Andrey Panin
2009-09-16 12:16 ` Andy Shevchenko
2009-09-16 12:26 ` [PATCH v2] " Andy Shevchenko
2009-09-16 12:43 ` Pekka Enberg [this message]
2009-09-16 13:53 ` [PATCH v3] " Andy Shevchenko
2009-09-16 15:34 ` Pekka Enberg
2009-09-16 13:54 ` [PATCH v2] " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020909160543s38daa8ebs989b9da09802d681@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=andy.shevchenko@gmail.com \
--cc=ext-andriy.shevchenko@nokia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®