From: Sam Ravnborg <sam@ravnborg.org>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [RFC Patch] kbuild: remove -Wdeclaration-after-statement
Date: Wed, 23 Sep 2009 12:51:57 +0200 [thread overview]
Message-ID: <20090923105157.GA31281@merkur.ravnborg.org> (raw)
In-Reply-To: <20090923094034.23512.90809.sendpatchset@localhost.localdomain>
On Wed, Sep 23, 2009 at 05:38:01AM -0400, Amerigo Wang wrote:
>
> I got lots of "ISO C90 forbids mixed declarations and code" warnings
> during compile today's kernel.
>
> I think we can remove the gcc option '-Wdeclaration-after-statement'
> now, since we already have C99 for 10 years. :)
This is a matter of style more than what C99 allows.
Kernel style is to fobid this(*) so we keep the warning.
(*) Based on reading several threads where this has
been mentioned - I have no specific references to CodingStyle.
Sam
next prev parent reply other threads:[~2009-09-23 10:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 9:38 Amerigo Wang
2009-09-23 10:19 ` Mikael Pettersson
2009-09-23 10:41 ` Johannes Weiner
2009-09-23 10:51 ` Sam Ravnborg [this message]
2009-09-25 20:18 ` Randy Dunlap
2009-09-25 20:52 ` Sam Ravnborg
2009-09-26 1:06 ` Amerigo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090923105157.GA31281@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®