From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
bluesmoke-devel@lists.sourceforge.net
Subject: Re: [PATCH 17/63] edac_mce: Add an interface driver to report mce errors via edac
Date: Fri, 25 Sep 2009 11:54:59 -0300 [thread overview]
Message-ID: <20090925115459.7621174a@pedra.chehab.org> (raw)
In-Reply-To: <20090925144720.38ea1c1f@infradead.org>
Em Fri, 25 Sep 2009 14:47:20 +0200
Arjan van de Ven <arjan@infradead.org> escreveu:
> On Fri, 25 Sep 2009 09:11:30 -0300
> Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
>
> > 5) there are very few calls to kernel routines here:
> > list_for_each_entry(), spin_lock_irqsave(), in_unlock_irqrestore(),
> > memcpy(). I don't think any of them will have any problems on working
> > even inside NMI context.
>
> spinlocks in NMI context don't do what you think they do....
> _irqsave does not disable NMIs so this can deadlock.
>
> You likely want to use trylock here....
I see. I'll rewrite that part of the code using trylock or RCU.
--
Cheers,
Mauro
next prev parent reply other threads:[~2009-09-25 14:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 22:27 Mauro Carvalho Chehab
2009-09-25 9:48 ` Borislav Petkov
2009-09-25 12:11 ` Mauro Carvalho Chehab
2009-09-25 12:47 ` Arjan van de Ven
2009-09-25 14:54 ` Mauro Carvalho Chehab [this message]
2009-09-25 13:56 ` Borislav Petkov
2009-09-25 14:05 ` Arjan van de Ven
2009-09-25 14:40 ` Borislav Petkov
2009-09-25 15:00 ` Arjan van de Ven
2009-09-25 14:46 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090925115459.7621174a@pedra.chehab.org \
--to=mchehab@redhat.com \
--cc=arjan@infradead.org \
--cc=bluesmoke-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®