Re: [GIT PULL] x86/txt for v2.6.32

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Monday 28 September 2009, Pavel Machek wrote:
> On Sat 2009-09-26 23:44:21, Rafael J. Wysocki wrote:
> > On Saturday 26 September 2009, Pavel Machek wrote:
> > > Hi!
> > > 
> > > >   git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git x86-txt-for-linus
> > > > 
> > > > Arnaldo Carvalho de Melo (1):
> > > >       x86, intel_txt: Fix typos in Kconfig help
> > > > 
> > > > H. Peter Anvin (3):
> > > >       x86, intel_txt: Factor out the code for S3 setup
> > > >       x86, intel_txt: Handle ACPI_SLEEP without X86_TRAMPOLINE
> > > 
> > > This went in despite my NAK/request for more info. It seems you are
> > > simply ignoring feedback you don't like :-(
> > 
> > The "x86, intel_txt: Handle ACPI_SLEEP without X86_TRAMPOLINE" commit looks
> > entirely correct to me.
> > 
> > I have no comments on "x86, intel_txt: Factor out the code for S3 setup" as
> > well, maybe except that the BUG() in tboot_setup_sleep() in the
> > !CONFIG_ACPI_SLEEP case is a bit unfortunate.
> 
> Well, I worry that S3 support for TXT makes TXT completely useless. A
> little liquid nitrogen, remove RAM, place it in another machine,
> modify it in any way you want, more liquid nitrogen, place it back.
> 
> Oops, protection provided by TXT is lost.

Ah, I see your point now.

Thanks,
Rafael