From: David Miller <davem@davemloft.net>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: Fix rio watchdog probe function
Date: Wed, 14 Oct 2009 01:18:46 -0700 (PDT) [thread overview]
Message-ID: <20091014.011846.39805804.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.2.00.0910101201470.9428@localhost.localdomain>
From: Thomas Gleixner <tglx@linutronix.de>
Date: Sat, 10 Oct 2009 12:03:28 +0200 (CEST)
> After sucessfully registering the misc device the driver iounmaps the
> hardware registers and kfree's the device data structure. Ouch !
>
> This was introduced with commit e42311d75 (riowatchdog: Convert to
> pure OF driver) and went unnoticed for more than a year :)
>
> Return success instead of dropping into the error cleanup code path.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Applied and queued up for -stable, thanks!
prev parent reply other threads:[~2009-10-14 8:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-10 10:03 Thomas Gleixner
2009-10-14 8:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091014.011846.39805804.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome