From: Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
Yinghai Lu <yhlu.kernel@gmail.com>,
Arjan van de Ven <arjan@infradead.org>,
David Miller <davem@davemloft.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: nfs mount fail
Date: Mon, 19 Oct 2009 09:08:25 +0200 [thread overview]
Message-ID: <20091019070825.GA16493@elte.hu> (raw)
In-Reply-To: <1255935518.18914.0.camel@penberg-laptop>
* Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> Hi Ingo,
>
> On Mon, 2009-10-19 at 08:54 +0200, Ingo Molnar wrote:
> > * Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> >
> > > > yes. something miss merged again...
> > > >
> > > > need change some lines.
> > >
> > > This doesn't match mainline either. To do so, the above kfree() has to
> > > be at the end of the "Opt_xprt_rdma:" case...
> >
> > it's from a test patch in tip:out-of-tree:
> >
> > d40bc6b: <not-for-merge> nfs: fix nfs_parse_mount_options() double kfree()
> >
> > (attached below)
> >
> > that fix is wrong apparently - is there a correct fix upstream perhaps?
>
> AFAICT, yes. See commit d508afb437daee7cf07da085b635c44a4ebf9b38 ("NFS:
> Fix a double free in nfs_parse_mount_options()") from Trond.
sigh. That was written 3 days after your and Yinghai's patch was sent -
there's no Reported-by credit, there was no Cc: back to the original
thread - plus there was a memory leak was left in there as well. Trond?
Ingo
next prev parent reply other threads:[~2009-10-19 7:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-18 1:25 Yinghai Lu
2009-10-18 4:22 ` Yinghai Lu
2009-10-19 2:35 ` Pekka Enberg
2009-10-19 2:43 ` Arjan van de Ven
2009-10-19 2:58 ` Pekka Enberg
2009-10-19 5:52 ` Yinghai Lu
2009-10-19 6:30 ` Trond Myklebust
2009-10-19 6:54 ` Ingo Molnar
2009-10-19 6:58 ` Pekka Enberg
2009-10-19 7:08 ` Ingo Molnar [this message]
2009-10-19 7:31 ` Yinghai Lu
2009-10-19 7:52 ` Trond Myklebust
2009-10-19 8:04 ` Ingo Molnar
2009-10-19 8:23 ` Ingo Molnar
2009-10-19 8:29 ` Trond Myklebust
2009-10-19 8:39 ` [PATCH] nfs: Fix nfs_parse_mount_options() kfree() leak Ingo Molnar
2009-10-19 7:04 ` [re-send PATCH] nfs: Fix nfs_parse_mount_options() double kfree() Ingo Molnar
2009-10-19 7:10 ` Ingo Molnar
2009-10-19 7:04 ` nfs mount fail Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091019070825.GA16493@elte.hu \
--to=mingo@elte.hu \
--cc=arjan@infradead.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=trond.myklebust@fys.uio.no \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®