* [PATCH] PM: Make warning in suspend_test_finish() less likely to happen
@ 2009-10-20 4:45 Rafael J. Wysocki
0 siblings, 0 replies; only message in thread
From: Rafael J. Wysocki @ 2009-10-20 4:45 UTC (permalink / raw)
To: pm list; +Cc: LKML, Linus Torvalds
From: Rafael J. Wysocki <rjw@sisk.pl>
Increase TEST_SUSPEND_SECONDS to 10 so the warning in
suspend_test_finish() doesn't annoy the users of slower systems so
much.
Also, make the warning print the suspend-resume cycle time, so
that we know why the warning actually triggered.
Patch prepared during the hacking session at the Kernel Summit in
Tokyo.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
kernel/power/suspend_test.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Index: linux-2.6/kernel/power/suspend_test.c
===================================================================
--- linux-2.6.orig/kernel/power/suspend_test.c
+++ linux-2.6/kernel/power/suspend_test.c
@@ -19,7 +19,7 @@
* The time it takes is system-specific though, so when we test this
* during system bootup we allow a LOT of time.
*/
-#define TEST_SUSPEND_SECONDS 5
+#define TEST_SUSPEND_SECONDS 10
static unsigned long suspend_test_start_time;
@@ -49,7 +49,8 @@ void suspend_test_finish(const char *lab
* has some performance issues. The stack dump of a WARN_ON
* is more likely to get the right attention than a printk...
*/
- WARN(msec > (TEST_SUSPEND_SECONDS * 1000), "Component: %s\n", label);
+ WARN(msec > (TEST_SUSPEND_SECONDS * 1000),
+ "Component: %s, time: %u\n", label, msec);
}
/*
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-10-20 4:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-20 4:45 [PATCH] PM: Make warning in suspend_test_finish() less likely to happen Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®