From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: David Vrabel <david.vrabel@csr.com>
Cc: Nicolas Pitre <nico@fluxnic.net>, Alan Cox <alan@linux.intel.com>,
linux-mmc@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
dhowells@redhat.com
Subject: Re: [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code
Date: Tue, 3 Nov 2009 14:17:23 +0000 [thread overview]
Message-ID: <20091103141723.21c2bea1@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4AF03720.5070506@csr.com>
> > sdio_uart_irq
> > sdio_uart_port_remove
> > port->func = NULL;
> > sdio_in
> > BUG_ON
>
> This is actually happening? sdio_claim_host()/sdio_release_host() act
Found by inspection
> like a mutex so sdio_uart_port_remove() will wait in sdio_claim_host()
> until sdio_uart_irq() returns (SDIO interrupt handlers are called with
> the host claimed).
Ok that was a detail I was missing. That part of the locking now makes
sense.
Ok so I think I have it fixed up barring stuff which is "feature add" -
such as implementing TIOCMIWAIT and blocking on no carrier.
prev parent reply other threads:[~2009-11-03 14:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 16:44 Alan Cox
2009-11-02 16:45 ` [PATCH 1/6] sdio_uart: refcount the tty objects Alan Cox
2009-11-02 16:45 ` [PATCH 2/6] sdio_uart: Move the open lock Alan Cox
2009-11-02 16:45 ` [PATCH 3/6] sdio_uart: Switch to the open/close helpers Alan Cox
2009-11-02 16:46 ` [PATCH 4/6] sdio_uart: Fix termios handling Alan Cox
2009-11-02 16:46 ` [PATCH 5/6] sdio_uart: Use kfifo instead of the messy circ stuff Alan Cox
2009-11-02 16:46 ` [PATCH 6/6] sdio_uart: Style fixes Alan Cox
2009-11-02 17:51 ` [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code Nicolas Pitre
2009-11-02 19:16 ` Alan Cox
2009-11-02 21:57 ` Nicolas Pitre
2009-11-02 22:35 ` Alan Cox
2009-11-03 0:30 ` Nicolas Pitre
2009-11-03 12:06 ` Alan Cox
2009-11-03 13:58 ` David Vrabel
2009-11-03 14:17 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091103141723.21c2bea1@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=david.vrabel@csr.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®