From: Nicolas Pitre <nico@fluxnic.net>
To: Alan Cox <alan@linux.intel.com>
Cc: linux-mmc@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
dhowells@redhat.com
Subject: Re: [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code
Date: Mon, 02 Nov 2009 12:51:12 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.0911021243040.13333@xanadu.home> (raw)
In-Reply-To: <20091102164039.11877.88825.stgit@localhost.localdomain>
On Mon, 2 Nov 2009, Alan Cox wrote:
> This sorts out the sdio uart handling of the tty layer. The existing code
> has lots of races and other fun bugs. Beat it into the current tty format for
> hotpluggable devices. The updates are intentionally modelled on Alan Stern's
> USB serial approach which is defintiely "best practice" right now. Also clean
> it up as we go and sort the circ stuff out.
Thanks.
> I don't have hardware to test this so hopefully someone out there does,
> otherwise given the nature of the bugs involved the driver will be progressed
> to BROKEN and removal.
I still have the hardware. Even tested it recently with a new SDIO host
controller and it "worked just fine". Hardware is a GPS receiver so
admitedly nothing that would push this driver into corner cases.
However I have problems applying your patches. Most of them require
fuzzy patching to apply, and one of them even doesn't apply that way.
What is your base tree?
Nicolas
next prev parent reply other threads:[~2009-11-02 17:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 16:44 Alan Cox
2009-11-02 16:45 ` [PATCH 1/6] sdio_uart: refcount the tty objects Alan Cox
2009-11-02 16:45 ` [PATCH 2/6] sdio_uart: Move the open lock Alan Cox
2009-11-02 16:45 ` [PATCH 3/6] sdio_uart: Switch to the open/close helpers Alan Cox
2009-11-02 16:46 ` [PATCH 4/6] sdio_uart: Fix termios handling Alan Cox
2009-11-02 16:46 ` [PATCH 5/6] sdio_uart: Use kfifo instead of the messy circ stuff Alan Cox
2009-11-02 16:46 ` [PATCH 6/6] sdio_uart: Style fixes Alan Cox
2009-11-02 17:51 ` Nicolas Pitre [this message]
2009-11-02 19:16 ` [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code Alan Cox
2009-11-02 21:57 ` Nicolas Pitre
2009-11-02 22:35 ` Alan Cox
2009-11-03 0:30 ` Nicolas Pitre
2009-11-03 12:06 ` Alan Cox
2009-11-03 13:58 ` David Vrabel
2009-11-03 14:17 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0911021243040.13333@xanadu.home \
--to=nico@fluxnic.net \
--cc=alan@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®