From: Wim Van Sebroeck <wim@iguana.be>
To: Denis Turischev <denis@compulab.co.il>
Cc: LKML <linux-kernel@vger.kernel.org>,
Mike Rapoport <mike@compulab.co.il>,
Andrey Panin <pazke@centrinvest.ru>
Subject: Re: SBC-FITPC2 watchdog driver fix
Date: Thu, 5 Nov 2009 12:51:47 +0100 [thread overview]
Message-ID: <20091105115147.GY3999@infomag.iguana.be> (raw)
In-Reply-To: <4AF2B7D8.1010903@compulab.co.il>
Hi Denis,
added in linux-2.6-watchdog-next for further testing.
Will sent this to Linus in a couple of days.
Kind regards,
Wim.
> Signed-off-by: Denis Turischev <denis@compulab.co.il>
>
> This patch fixes device registration process.
>
> diff -Nru linux-2.6.32-rc6.orig/drivers/watchdog/sbc_fitpc2_wdt.c
> linux-2.6.32-rc6/drivers/watchdog/sbc_fitpc2_wdt.c
> --- linux-2.6.32-rc6.orig/drivers/watchdog/sbc_fitpc2_wdt.c
> 2009-11-03 21:37:49.000000000 +0200
> +++ linux-2.6.32-rc6/drivers/watchdog/sbc_fitpc2_wdt.c 2009-11-05
> 13:23:11.000000000 +0200
> @@ -227,7 +227,7 @@
> }
>
> err = misc_register(&fitpc2_wdt_miscdev);
> - if (!err) {
> + if (err) {
> pr_err("cannot register miscdev on minor=%d (err=%d)\n",
> WATCHDOG_MINOR,
> err);
> goto err_margin;
next prev parent reply other threads:[~2009-11-05 11:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 15:53 [PATCH] add SBC-FITPC2 watchdog driver Mike Rapoport
2009-07-20 16:43 ` Joe Perches
2009-07-21 4:34 ` [PATCH 0/3] drivers/watchdog: Use pr_<level> Joe Perches
2009-07-21 4:35 ` [PATCH 1/3] include/linux: kernel.h dynamic_debug.h device.h - Use section fmts Joe Perches
2009-07-21 4:35 ` [PATCH 2/3] drivers/watchdog: Convert printk(KERN_<level> to pr_<level>( Joe Perches
2009-07-21 4:35 ` [PATCH 3/3] drivers/watchdog: use pr_fmt Joe Perches
2009-11-05 11:32 ` SBC-FITPC2 watchdog driver fix Denis Turischev
2009-11-05 11:51 ` Wim Van Sebroeck [this message]
2010-01-21 14:10 ` Denis Turischev
2010-04-22 16:50 ` I/O operations order fix for SBC-FITPC2 watchdog Denis Turischev
2010-04-22 16:54 ` "scheduling while atomic" bug in " Denis Turischev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091105115147.GY3999@infomag.iguana.be \
--to=wim@iguana.be \
--cc=denis@compulab.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@compulab.co.il \
--cc=pazke@centrinvest.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®