From: Robin Holt <holt@sgi.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Robin Holt <holt@sgi.com>, Jack Steiner <steiner@sgi.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [patch 6/6] X86: UV - xpc_make_first_contact hang due to not accepting ACTIVE state.
Date: Mon, 09 Nov 2009 11:09:00 -0600 [thread overview]
Message-ID: <20091109170907.436556000@alcatraz.americas.sgi.com> (raw)
In-Reply-To: <20091109170854.161447000@alcatraz.americas.sgi.com>
[-- Attachment #1: xpc_first_contact_when_active --]
[-- Type: text/plain, Size: 1395 bytes --]
Many times while the initial connection is being made, the
contacted partition will send back both the ACTIVATING and the ACTIVE
remote_act_state changes in very close succescion. The 1/4 second delay
in the make first contact loop is large enough to nearly always miss
the ACTIVATING state change.
Since either state indicates the remote partition has acknowledged our
state change, accept either.
To: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Robin Holt <holt@sgi.com>
Cc: Jack Steiner <steiner@sgi.com>
Cc: lkml <linux-kernel@vger.kernel.org>
---
drivers/misc/sgi-xp/xpc_uv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-x86/drivers/misc/sgi-xp/xpc_uv.c
===================================================================
--- linux-x86.orig/drivers/misc/sgi-xp/xpc_uv.c 2009-11-09 09:13:14.000000000 -0600
+++ linux-x86/drivers/misc/sgi-xp/xpc_uv.c 2009-11-09 09:13:14.000000000 -0600
@@ -1022,7 +1022,8 @@ xpc_make_first_contact_uv(struct xpc_par
xpc_send_activate_IRQ_part_uv(part, &msg, sizeof(msg),
XPC_ACTIVATE_MQ_MSG_SYNC_ACT_STATE_UV);
- while (part->sn.uv.remote_act_state != XPC_P_AS_ACTIVATING) {
+ while (!((part->sn.uv.remote_act_state == XPC_P_AS_ACTIVATING) ||
+ (part->sn.uv.remote_act_state == XPC_P_AS_ACTIVE))) {
dev_dbg(xpc_part, "waiting to make first contact with "
"partition %d\n", XPC_PARTID(part));
prev parent reply other threads:[~2009-11-09 17:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 17:08 [patch 0/6] x86: UV - XPC fixes with related support functionality Robin Holt
2009-11-09 17:08 ` [patch 1/6] x86: UV - Introduce a means to translate from gpa -> socket_paddr Robin Holt
2009-11-09 17:08 ` [patch 2/6] x86: UV - XPC needs to provide an abstraction for uv_gpa Robin Holt
2009-11-09 17:08 ` [patch 3/6] x86: UV - Introduce uv_gpa_is_mmr Robin Holt
2009-11-09 17:08 ` [patch 4/6] x86: UV - Update XPC to handle updated BIOS interface Robin Holt
2009-11-09 17:08 ` [patch 5/6] x86: UV - XPC NULL deref when mesq becomes empty Robin Holt
2009-11-09 17:09 ` Robin Holt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091109170907.436556000@alcatraz.americas.sgi.com \
--to=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®