From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Jason Baron <jbaron@redhat.com>,
mingo@elte.hu, mhiramat@redhat.com, linux-kernel@vger.kernel.org,
hpa@zytor.com, tglx@linutronix.de, andi@firstfloor.org,
roland@redhat.com, rth@redhat.com
Subject: Re: [RFC PATCH 2/6] jump label v3 - x86: Introduce generic jump patching without stop_machine
Date: Wed, 18 Nov 2009 17:39:11 -0800 [thread overview]
Message-ID: <20091119013911.GG6683@linux.vnet.ibm.com> (raw)
In-Reply-To: <1258593767.22249.486.camel@gandalf.stny.rr.com>
On Wed, Nov 18, 2009 at 08:22:47PM -0500, Steven Rostedt wrote:
> On Wed, 2009-11-18 at 16:58 -0800, Paul E. McKenney wrote:
>
> > I do invoke smp_send_reschedule() with irqs disabled, which did arouse my
> > suspicions of late. But this seems to bypass the smp_call_function()
> > code that is most definitely illegal to invoke with irqs disabled,
> > so no smoking gun. All that aside, if invoking smp_send_reschedule()
> > with irqs disabled is in any way a bad idea, please let me know so I
> > can rearrange the code appropriately.
>
> I don't think you have anything to worry about here. If calling
> smp_send_reschedule was bad with keeping interrupts disabled, then we
> would have a lot of problems with the scheduler. That is called with the
> rq lock held and with interrupts disabled.
Whew!!! ;-)
Thanx, Paul
next prev parent reply other threads:[~2009-11-19 1:39 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 22:43 [RFC PATCH 0/6] jump label v3 Jason Baron
2009-11-18 22:43 ` [RFC PATCH 1/6] jump label v3 - kprobes/x86: Cleanup RELATIVEJUMP_INSTRUCTION to RELATIVEJUMP_OPCODE Jason Baron
2009-11-18 22:43 ` [RFC PATCH 2/6] jump label v3 - x86: Introduce generic jump patching without stop_machine Jason Baron
2009-11-19 0:28 ` Mathieu Desnoyers
2009-11-19 0:58 ` Paul E. McKenney
2009-11-19 1:22 ` Steven Rostedt
2009-11-19 1:39 ` Paul E. McKenney [this message]
2009-11-19 1:57 ` Mathieu Desnoyers
2009-11-19 4:16 ` Paul E. McKenney
2009-11-19 14:04 ` Masami Hiramatsu
2009-11-19 16:03 ` Mathieu Desnoyers
2009-11-20 1:00 ` Masami Hiramatsu
2009-11-21 15:32 ` Mathieu Desnoyers
2009-11-21 1:11 ` Masami Hiramatsu
2009-11-21 15:38 ` Mathieu Desnoyers
2009-11-20 21:54 ` H. Peter Anvin
2009-11-21 0:06 ` Masami Hiramatsu
2009-11-21 0:19 ` H. Peter Anvin
2009-11-21 16:21 ` Mathieu Desnoyers
2009-11-21 21:55 ` Masami Hiramatsu
2009-11-22 1:46 ` Mathieu Desnoyers
2009-11-21 16:12 ` Mathieu Desnoyers
2009-11-18 22:43 ` [RFC PATCH 3/6] jump label v3 - move opcode defs Jason Baron
2009-11-18 22:43 ` [RFC PATCH 4/6] jump label v3 - base patch Jason Baron
2009-11-18 23:38 ` [PATCH] notifier atomic call chain notrace Mathieu Desnoyers
2009-11-19 0:02 ` Paul E. McKenney
2009-11-19 3:59 ` Masami Hiramatsu
2009-11-19 16:48 ` Jason Baron
2009-11-18 22:43 ` [RFC PATCH 5/6] jump label v3 - add module support Jason Baron
2009-11-18 22:43 ` [RFC PATCH 6/6] jump label v3 - tracepoint support Jason Baron
2009-11-18 22:51 ` [RFC PATCH 0/6] jump label v3 H. Peter Anvin
2009-11-18 23:07 ` Roland McGrath
2009-11-18 23:18 ` H. Peter Anvin
2009-11-19 3:54 ` Roland McGrath
2009-11-19 21:55 ` Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091119013911.GG6683@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
--cc=rth@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome