mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: Stefan Assmann <sassmann@redhat.com>,
	linux-pci@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Krzysztof Halasa <khc@pm.waw.pl>, Don Dutile <ddutile@redhat.com>,
	kaneshige.kenji@jp.fujitsu.com
Subject: Re: [PATCH] change PCI nomenclature according to PCI-SIG
Date: Mon, 30 Nov 2009 08:11:47 -0800	[thread overview]
Message-ID: <20091130081147.274c8af0@jbarnes-piketon> (raw)
In-Reply-To: <4B126EEB.1040908@garzik.org>

On Sun, 29 Nov 2009 07:54:03 -0500
Jeff Garzik <jeff@garzik.org> wrote:

> Next, IMO, you don't have any idea how maintainers will react to this 
> patch, because you CC'd so few of them.  People who perform tree-wide 
> changes should take the time to CC __every__ relevant maintainer.  If 
> you are changing somebody's code, you should always let them know
> about it, and give them an opportunity to review the change. 
> scripts/get_maintainer.pl can help with this.
> 
> So, while the PCI maintainer might agree with the nomenclature
> change, he is not the most qualified person to state that your
> changes have no effect on drivers/edac/ppc4xx_edac.c, for example.

Honestly I'm not thrilled about it either.  Given the large
downside of making many oustanding diffs conflict, I'm wary of these
sorts of changes in general.  I suggested to Stefan that he just put
together one big patch to minimize that pain, but I didn't expect
something so huge (I was thinking it would be mainly limited to PCI
related files).

-- 
Jesse Barnes, Intel Open Source Technology Center

  parent reply	other threads:[~2009-11-30 16:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-28 11:54 Stefan Assmann
2009-11-28 12:43 ` Jeff Garzik
2009-11-29  9:09   ` Stefan Assmann
2009-11-29 12:54     ` Jeff Garzik
2009-11-29 15:12       ` Rafael J. Wysocki
2009-11-29 21:09       ` Krzysztof Halasa
2009-11-30  8:57       ` Stefan Assmann
2009-11-30 16:11       ` Jesse Barnes [this message]
2009-11-28 13:18 ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091130081147.274c8af0@jbarnes-piketon \
    --to=jbarnes@virtuousgeek.org \
    --cc=ddutile@redhat.com \
    --cc=jeff@garzik.org \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=khc@pm.waw.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®