mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Halasa <khc@pm.waw.pl>
To: Jeff Garzik <jeff@garzik.org>
Cc: Stefan Assmann <sassmann@redhat.com>,
	linux-pci@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Don Dutile <ddutile@redhat.com>,
	kaneshige.kenji@jp.fujitsu.com
Subject: Re: [PATCH] change PCI nomenclature according to PCI-SIG
Date: Sun, 29 Nov 2009 22:09:26 +0100	[thread overview]
Message-ID: <m34ood6nsp.fsf@intrepid.localdomain> (raw)
In-Reply-To: <4B126EEB.1040908@garzik.org> (Jeff Garzik's message of "Sun, 29 Nov 2009 07:54:03 -0500")

Jeff Garzik <jeff@garzik.org> writes:

> Think about this from an engineering perspective.  This patch is
> driven not by any real technical need, but more by marketing and
> trademark folks.

Uh, I'm not sure about this. It would be much better if the kernel was
consistent in naming the PCI versions, not like today: PCIe, PCIE,
PCI-E, PCI-express, PCI-X, PCIX etc, including the user-visible cases
(but obviously not the EDD and similar things).

But I think it should be handler by individual maintainers.

> Finally, split your patch up.  I would suggest starting with 100%
> comment changes that are guaranteed with mathematical certainty to not
> change the compiler-generated code at all.  That will make the
> remaining changes much easier to review, if they are in separate
> patches from the comment-only changes.

Absolutely. Perhaps that older PCI patch should be done first, it was
a good one IIRC.
-- 
Krzysztof Halasa

  parent reply	other threads:[~2009-11-29 21:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-28 11:54 Stefan Assmann
2009-11-28 12:43 ` Jeff Garzik
2009-11-29  9:09   ` Stefan Assmann
2009-11-29 12:54     ` Jeff Garzik
2009-11-29 15:12       ` Rafael J. Wysocki
2009-11-29 21:09       ` Krzysztof Halasa [this message]
2009-11-30  8:57       ` Stefan Assmann
2009-11-30 16:11       ` Jesse Barnes
2009-11-28 13:18 ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m34ood6nsp.fsf@intrepid.localdomain \
    --to=khc@pm.waw.pl \
    --cc=ddutile@redhat.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jeff@garzik.org \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome