mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: william.allen.simpson@gmail.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: warning: massive change to conditional coding style in net?
Date: Tue, 01 Dec 2009 15:28:43 -0800 (PST)	[thread overview]
Message-ID: <20091201.152843.207086860.davem@davemloft.net> (raw)
In-Reply-To: <4B1558D8.4010804@gmail.com>

From: William Allen Simpson <william.allen.simpson@gmail.com>
Date: Tue, 01 Dec 2009 12:56:40 -0500

> Heck, changes to comments!

Comments help people understand your code.  Long after you're gone and
no longer around, other people will need to read your code, maintain
it, and fix bugs in it.

That's why well written and properly formatted comments are important.

Again, nobody is picking on your specifically, everyone goes through
this review process.  What is unique about you is that you're the only
one who throws rotten tomatoes back at the reviewers instead of simply
fixing up your patch set and resubmitting.

If the changes requested are so simple and trivial, then it should
take you but a few minutes to respin your patches with the fixes
included.

It definitely takes you more effort to write all of these angry
emails, but how you spend your time is your choice.

      parent reply	other threads:[~2009-12-01 23:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-30 10:36 William Allen Simpson
2009-11-30 13:44 ` Jarek Poplawski
2009-11-30 13:54   ` Alan Cox
2009-11-30 19:39     ` Jarek Poplawski
2009-11-30 17:56 ` Joe Perches
2009-12-01 16:08   ` William Allen Simpson
2009-12-01 16:49     ` Eric Dumazet
2009-12-01 17:43     ` Jarek Poplawski
2009-11-30 20:36 ` David Miller
2009-12-01 17:56   ` William Allen Simpson
2009-12-01 18:30     ` Eric Dumazet
2009-12-01 23:28     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091201.152843.207086860.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=william.allen.simpson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome