Re: [PATCH 06/11] pps: serial clients support.

[Rodolfo Giometti <giometti@enneenne.com>]

On Wed, Dec 02, 2009 at 06:59:03PM +0000, Alan Cox wrote:
> On Wed,  2 Dec 2009 18:18:44 +0100
> Rodolfo Giometti <giometti@linux.it> wrote:
> 
> > Adds support, by using the PPS line discipline, for the PPS sources
> > connected with the CD (Carrier Detect) pin of a serial port.
> 
> I would suggest one change here - but the pps-ldisc bits into the n_tty.c
> file then you don't have to export everything. That or just export the
> n_tty ops struct.
> 
> I think putting the pps ldisc (which is basically n_tty and a bit) into
> n_tty is probably the right choice given how small and clean it is - what
> do you think ?

I think it could be ok, but in this case where should I register
pps-ldisc? Into tty_ldisc_begin just after tty_ldisc_N_TTY?

Again, should I remove the possibility to compile pps-ldisc as module?

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail: giometti@enneenne.com
Linux Device Driver                          giometti@linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it