From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>,
Dave Jones <davej@redhat.com>, Sam Ravnborg <sam@ravnborg.org>,
Greg KH <greg@kroah.com>, Randy Dunlap <randy.dunlap@oracle.com>,
Kay Sievers <kay.sievers@vrfy.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 06/11] pps: serial clients support.
Date: Thu, 3 Dec 2009 12:24:58 +0000 [thread overview]
Message-ID: <20091203122458.16bb57d2@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20091203120523.GE12943@gundam.enneenne.com>
> > void n_tty_init_ops(struct tty_ldisc_ops *ops)
> > {
> > *ops = tty_ldisc_N_TTY;
> > ops->owner = NULL:
> > ops->refcount = ops->flags = 0;
> > }
> > EXPORT_SYMBOL_GPL(n_tty_inherit_ops);
>
> The problem is that I have to do some operations into ldisc's open and
> close methods (see linux/drivers/pps/clients/pps-ldisc.c).
>
> By using your solution I inherit such methods but I cannot modify
> their behaviour in a manner suitable for register/deregister PPS
> support at runtime.
You can
n_tty_init_ops(&my_ops);
my_ops.num = whatever;
old_open = my_ops.open;
my_ops.open = pps_ntty_open;
etc
While not as pretty in C as C++ it works fine.
next prev parent reply other threads:[~2009-12-03 12:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 17:18 LinuxPPS new functionalities Rodolfo Giometti
2009-12-02 17:18 ` [PATCH 01/11] pps: userland header file for PPS API Rodolfo Giometti
2009-12-02 17:18 ` [PATCH 02/11] pps: documentation programs and examples Rodolfo Giometti
2009-12-02 17:18 ` [PATCH 03/11] pps: LinuxPPS clients support Rodolfo Giometti
2009-12-02 17:18 ` [PATCH 04/11] ldisc: new dcd_change() method for line disciplines Rodolfo Giometti
2009-12-02 17:18 ` [PATCH 05/11] ldisc n_tty: export all N_TTY ldisc methods Rodolfo Giometti
2009-12-02 17:18 ` [PATCH 06/11] pps: serial clients support Rodolfo Giometti
2009-12-02 17:18 ` [PATCH 07/11] serial 8250: enable PPS support Rodolfo Giometti
2009-12-02 17:18 ` [PATCH 08/11] pps: parallel port clients support Rodolfo Giometti
2009-12-02 17:18 ` [PATCH 09/11] pps: low level IRQ timestamps recording Rodolfo Giometti
2009-12-02 17:18 ` [PATCH 10/11] serial amba-pl010: enable PPS support Rodolfo Giometti
2009-12-02 17:18 ` [PATCH 11/11] arm: add low level IRQ timestamps recording for arm platforms Rodolfo Giometti
2009-12-03 0:10 ` [PATCH 09/11] pps: low level IRQ timestamps recording H. Peter Anvin
2009-12-03 12:01 ` Rodolfo Giometti
2009-12-05 6:46 ` H. Peter Anvin
2009-12-02 18:59 ` [PATCH 06/11] pps: serial clients support Alan Cox
2009-12-03 10:53 ` Rodolfo Giometti
2009-12-03 11:46 ` Alan Cox
2009-12-03 12:05 ` Rodolfo Giometti
2009-12-03 12:24 ` Alan Cox [this message]
2009-12-02 18:18 ` [PATCH 05/11] ldisc n_tty: export all N_TTY ldisc methods Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091203122458.16bb57d2@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=dwmw2@infradead.org \
--cc=giometti@enneenne.com \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mtk.manpages@gmail.com \
--cc=randy.dunlap@oracle.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®