From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Alex Williamson <alex.williamson@hp.com>
Cc: yinghai@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, alex.williamson@hp.com
Subject: Re: [PATCH v2] PCI: Always set prefetchable base/limit upper32 registers
Date: Fri, 4 Dec 2009 16:01:58 -0800 [thread overview]
Message-ID: <20091204160158.1b591cb1@jbarnes-piketon> (raw)
In-Reply-To: <20091130214954.10845.23072.stgit@debian.lart>
On Mon, 30 Nov 2009 14:51:44 -0700
Alex Williamson <alex.williamson@hp.com> wrote:
> Prior to 1f82de10 we always initialized the upper 32bits of the
> prefetchable memory window, regardless of the address range used.
> Now we only touch it for a >32bit address, which means the upper32
> registers remain whatever the BIOS initialized them too.
>
> It's valid for the BIOS to set the upper32 base/limit to
> 0xffffffff/0x00000000, which makes us program prefetchable ranges
> like 0xffffffffabc00000 - 0x00000000abc00000
>
> Revert the chunk of 1f82de10 that made this conditional so we always
> write the upper32 registers and remove now unused pref_mem64 variable.
>
> Signed-off-by: Alex Williamson <alex.williamson@hp.com>
> ---
>
Applied this one, though it looks like your diff had some context that
wasn't in my tree. Please double check that I fixed it up correctly.
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2009-12-05 0:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 21:51 Alex Williamson
2009-12-01 0:03 ` Grant Grundler
2009-12-01 0:19 ` Grant Grundler
2009-12-01 1:23 ` Yinghai Lu
2009-12-01 4:10 ` Alex Williamson
2009-12-01 19:55 ` Grant Grundler
2009-12-01 20:40 ` Yinghai Lu
2009-12-01 20:59 ` Grant Grundler
2009-12-01 21:14 ` Yinghai Lu
2009-12-05 0:01 ` Jesse Barnes [this message]
2009-12-05 14:49 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091204160158.1b591cb1@jbarnes-piketon \
--to=jbarnes@virtuousgeek.org \
--cc=alex.williamson@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®