pass upstream rev to scripts/get_maintainer.pl

pass upstream rev to scripts/get_maintainer.pl

[Uwe Kleine-König]

Hello,

I often face the "problem" that get_maintainer.pl yields my name, too,
as the commits I want to send are included in HEAD.

I think the nicest fix for that would be to be able to pass an upstream
rev à la:

	scripts/get_maintainer.pl --upstream linus/master ...

.  As my knowledge of perl is quite limited I only provide you with
my quick'n'dirty patch I usually use, just to give you an idea.

Best regards
Uwe

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 81a67a4..2f27c13 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -715,7 +715,7 @@ sub recent_git_signoffs {
 	return;
     }
 
-    $cmd = "git log --since=${email_git_since} -- ${file}";
+    $cmd = "git log --since=${email_git_since} linus/master -- ${file}";
 
     $output = `${cmd}`;
     $output =~ s/^\s*//gm;
@@ -785,12 +785,12 @@ sub git_assign_blame {
 	    my $diff_start = $2;
 	    my $diff_length = $3;
 	    next if (!("$file" eq "$diff_file"));
-	    $cmd = "git blame -l -L $diff_start,+$diff_length $file";
+	    $cmd = "git blame -l -L $diff_start,+$diff_length linus/master -- $file";
 	    @commits = save_commits($cmd, @commits);
 	}
     } else {
 	if (-f $file) {
-	    $cmd = "git blame -l $file";
+	    $cmd = "git blame -l linus/master -- $file";
 	    @commits = save_commits($cmd, @commits);
 	}
     }

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |

Re: pass upstream rev to scripts/get_maintainer.pl

[Joe Perches]

On Wed, 2009-12-09 at 10:06 +0100, Uwe Kleine-König wrote:
> I often face the "problem" that get_maintainer.pl yields my name, too,
> as the commits I want to send are included in HEAD.

Why is this a problem?

If you are using git send-email, does adding
--suppress-cc=self solve it?

Re: pass upstream rev to scripts/get_maintainer.pl

[Mark Brown]

On Wed, Dec 09, 2009 at 06:07:47AM -0800, Joe Perches wrote:
> On Wed, 2009-12-09 at 10:06 +0100, Uwe Kleine-K??nig wrote:
> > I often face the "problem" that get_maintainer.pl yields my name, too,
> > as the commits I want to send are included in HEAD.

> Why is this a problem?

With the limit on the number of people returned it's possible that
authors of the patch series being posted (there may be more than one)
will push out folks that it'd be good to include.

Re: pass upstream rev to scripts/get_maintainer.pl

[Joe Perches]

On Wed, 2009-12-09 at 14:13 +0000, Mark Brown wrote:
> On Wed, Dec 09, 2009 at 06:07:47AM -0800, Joe Perches wrote:
> > On Wed, 2009-12-09 at 10:06 +0100, Uwe Kleine-K??nig wrote:
> > > I often face the "problem" that get_maintainer.pl yields my name, too,
> > > as the commits I want to send are included in HEAD.
> > Why is this a problem?
> With the limit on the number of people returned it's possible that
> authors of the patch series being posted (there may be more than one)
> will push out folks that it'd be good to include.

You could use --git-max-maintainers=<value more than default>

Re: pass upstream rev to scripts/get_maintainer.pl

[Mark Brown]

On Wed, Dec 09, 2009 at 06:23:02AM -0800, Joe Perches wrote:
> On Wed, 2009-12-09 at 14:13 +0000, Mark Brown wrote:

> > With the limit on the number of people returned it's possible that
> > authors of the patch series being posted (there may be more than one)
> > will push out folks that it'd be good to include.

> You could use --git-max-maintainers=<value more than default>

Of course, for that use case the patch is just a potentially clearer
idiom for doing it.

Re: pass upstream rev to scripts/get_maintainer.pl

[Uwe Kleine-König]

On Wed, Dec 09, 2009 at 06:07:47AM -0800, Joe Perches wrote:
> On Wed, 2009-12-09 at 10:06 +0100, Uwe Kleine-König wrote:
> > I often face the "problem" that get_maintainer.pl yields my name, too,
> > as the commits I want to send are included in HEAD.
> 
> Why is this a problem?
> 
> If you are using git send-email, does adding
> --suppress-cc=self solve it?
I use get_maintainer.pl to add Cc: entries to changelogs, not as cc-prog
of git send-email.  So the alternative solution is to use grep here.
Anyhow I consider the suggestion I pointed out nicer.

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |