* [PATCH 2/9] drivers/atm: Correct code taking the size of a pointer
@ 2009-12-13 11:40 Julia Lawall
2009-12-14 3:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2009-12-13 11:40 UTC (permalink / raw)
To: chas, linux-atm-general, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
sizeof(TstSchedTbl) is just the size of the pointer. Change it to the size
of the referenced data.
A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression *x;
expression f;
type T;
@@
*f(...,(T)x,...)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/atm/iphase.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index f734b34..6b73c2b 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -557,7 +557,7 @@ static int ia_cbr_setup (IADEV *dev, struct atm_vcc *vcc) {
memcpy((caddr_t)&cbrVC,(caddr_t)TstSchedTbl,sizeof(cbrVC));
} /* while */
// Move this VCI number into this location of the CBR Sched table.
- memcpy((caddr_t)TstSchedTbl, (caddr_t)&vcIndex,sizeof(TstSchedTbl));
+ memcpy((caddr_t)TstSchedTbl, (caddr_t)&vcIndex, sizeof(*TstSchedTbl));
dev->CbrRemEntries--;
toBeAssigned--;
} /* while */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/9] drivers/atm: Correct code taking the size of a pointer
2009-12-13 11:40 [PATCH 2/9] drivers/atm: Correct code taking the size of a pointer Julia Lawall
@ 2009-12-14 3:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-12-14 3:57 UTC (permalink / raw)
To: julia; +Cc: chas, linux-atm-general, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Date: Sun, 13 Dec 2009 12:40:55 +0100 (CET)
> From: Julia Lawall <julia@diku.dk>
>
> sizeof(TstSchedTbl) is just the size of the pointer. Change it to the size
> of the referenced data.
>
> A simplified version of the semantic patch that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-14 3:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-13 11:40 [PATCH 2/9] drivers/atm: Correct code taking the size of a pointer Julia Lawall
2009-12-14 3:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®